Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

2017-10-21 Thread Jordan Ly
> On Oct. 21, 2017, 4 p.m., Bill Farner wrote: > > FYI i'm in no rush, but awaiting an explicit ship it from Jordan. Want to > > make sure everyone is on board with this! Apologies for the delay everyone! Code-wise the patch looks good, but I would like to test it at scale for extra

Re: Review Request 63202: Add test case for regression of AURORA-1952

2017-10-21 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63202/#review188900 --- Ship it! Ship It! - Jordan Ly On Oct. 21, 2017, 2:44 p.m.,

Re: Review Request 63202: Add test case for regression of AURORA-1952

2017-10-21 Thread Mohit Jaggi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63202/#review188899 --- Ship it! lgtm - Mohit Jaggi On Oct. 21, 2017, 2:44 p.m.,

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

2017-10-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62869/#review188898 --- Ship it! Ship It! - David McLaughlin On Oct. 18, 2017, 6:11

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

2017-10-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62869/#review188897 --- FYI i'm in no rush, but awaiting an explicit ship it from Jordan.

Re: Review Request 63202: Add test case for regression of AURORA-1952

2017-10-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63202/#review188896 --- Ship it! Master (9825e05) is green with this patch.

Review Request 63202: Add test case for regression of AURORA-1952

2017-10-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63202/ --- Review request for Aurora and Jordan Ly. Repository: aurora Description

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review188890 --- Ship it! Master (9825e05) is green with this patch.

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review19 --- Master (9825e05) is red with this patch.

Re: Review Request 63121: Remove static bans for task groups that are no longer pending

2017-10-21 Thread Jordan Ly
> On Oct. 20, 2017, 3:16 p.m., Bill Farner wrote: > > Capturing some offline analysis/discussion - under certain conditions this > > patch might do more harm than good. In clusters with very high churn rates > > (e.g. services being rescheduled frequently, high cron volume), static bans > >

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review17 --- Master (9825e05) is red with this patch.