Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62869/#review189160 --- Master (38476ab) is green with this patch.

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

> On Oct. 24, 2017, 9:53 a.m., Jordan Ly wrote: > > Overall LGTM! Tested upgrade/downgrade paths at scale and it seems to work > > well. > > Stephan Erb wrote: > Pure curiosity on my end: the benchmarks show pretty impressive speed > improvements. Are those also noticeable in practice for

Re: Review Request 63236: Refactor veto logic to use direct method calls as opposed to pubsub events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63236/#review189152 --- Ship it! - Bill Farner On Oct. 24, 2017, 12:10 a.m., Jordan

Re: Review Request 63282: Remove the old UI and serve the new UI instead

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63282/#review189150 --- Ship it! Ship It! - Bill Farner On Oct. 24, 2017, 5:21

Re: Review Request 63282: Remove the old UI and serve the new UI instead

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63282/#review189139 --- Master (38476ab) is red with this patch.

Re: Review Request 63282: Remove the old UI and serve the new UI instead

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63282/#review189138 --- @ReviewBot retry - David McLaughlin On Oct. 25, 2017, 12:21

Re: Review Request 63281: Clean up TaskList component layout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63281/#review189118 --- Ship it! Master (38476ab) is green with this patch.

Re: Review Request 63221: reload instance page once a neighbor item is clicked

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review189110 --- ui/src/main/js/pages/Instance.js Lines 2 (patched)

Re: Review Request 63261: Do not reserve agents for updates when constraints change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63261/#review189099 --- Ship it! Master (a673c5b) is green with this patch.

Re: Review Request 63260: Fix alignment of text on JobList

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63260/#review189098 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 24,

Re: Review Request 63260: Fix alignment of text on JobList

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63260/#review189096 --- Ship it! Ship It! - Kai Huang On Oct. 24, 2017, 8:44 p.m.,

Review Request 63262: Add a package.json file in the plugin directory to allow custom dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63262/ --- Review request for Aurora and Reza Motamedi. Repository: aurora Description

Re: Review Request 63261: Do not reserve agents for updates when constraints change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63261/#review189092 --- Ship it! Ship It! - Reza Motamedi On Oct. 24, 2017, 9:19

Review Request 63261: Do not reserve agents for updates when constraints change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63261/ --- Review request for Aurora and Jordan Ly. Repository: aurora Description

Re: Review Request 63260: Fix alignment of text on JobList

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63260/#review189086 --- Ship it! Master (a673c5b) is green with this patch.

Review Request 63260: Fix alignment of text on JobList

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63260/ --- Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar

Re: Review Request 63236: Refactor veto logic to use direct method calls as opposed to pubsub events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63236/#review189080 --- Ship it!

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

> On Okt. 24, 2017, 6:53 nachm., Jordan Ly wrote: > > Overall LGTM! Tested upgrade/downgrade paths at scale and it seems to work > > well. Pure curiosity on my end: the benchmarks show pretty impressive speed improvements. Are those also noticeable in practice for you? - Stephan

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62869/#review189062 --- Ship it! Overall LGTM! Tested upgrade/downgrade paths at scale

Re: Review Request 63236: Refactor veto logic to use direct method calls as opposed to pubsub events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63236/#review189031 --- Ship it! Master (a673c5b) is green with this patch.

Review Request 63236: Refactor veto logic to use direct method calls as opposed to pubsub events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63236/ --- Review request for Aurora and Bill Farner. Repository: aurora Description