Re: Review Request 63743: Remove the internal SQL database

2017-11-11 Thread Bill Farner
> On Nov. 11, 2017, 11:14 a.m., Jordan Ly wrote: > > Should we remove `GatingDelayExecutor`/`GatedWorkQueue` as well? I believe > > they are only used in DB stores. Sure, done. This required a bit of a refactor, so you'll notice the diff has grown a bit more complex. - Bill

Re: Review Request 63744: Remove LockStore

2017-11-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63744/#review190787 --- Master (9b9b2ee) is red with this patch.

Re: Review Request 63743: Remove the internal SQL database

2017-11-11 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63743/#review190785 --- Should we remove `GatingDelayExecutor`/`GatedWorkQueue` as well?

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-11-11 Thread Renan DelValle
> On Nov. 9, 2017, 6:04 p.m., Renan DelValle wrote: > > I'm all for the upgrade to Thrift 0.10.0 but we should announce plans to > > upgrade ASAP to the mailing lists because it'll break every go thrift > > client due to https://issues.apache.org/jira/browse/THRIFT-3467 . It says > > it was

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-11-11 Thread Bill Farner
> On Nov. 9, 2017, 6:04 p.m., Renan DelValle wrote: > > I'm all for the upgrade to Thrift 0.10.0 but we should announce plans to > > upgrade ASAP to the mailing lists because it'll break every go thrift > > client due to https://issues.apache.org/jira/browse/THRIFT-3467 . It says > > it was

Re: Review Request 63744: Remove LockStore

2017-11-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63744/#review190780 --- Master (9b9b2ee) is red with this patch.

Re: Review Request 63743: Remove the internal SQL database

2017-11-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63743/#review190779 --- Master (9b9b2ee) is green with this patch.

Re: Review Request 63743: Remove the internal SQL database

2017-11-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63743/#review190778 --- Ship it! Ship It! - Stephan Erb On Nov. 11, 2017, 5:53

Review Request 63744: Remove LockStore

2017-11-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63744/ --- Review request for Aurora, Jordan Ly and Stephan Erb. Repository: aurora