Re: Review Request 64015: Replace node-sass with sass.js

2017-11-21 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64015/#review191692 --- Ship it! Ship It! - Jordan Ly On Nov. 22, 2017, 1:07 a.m.,

Review Request 64015: Replace node-sass with sass.js

2017-11-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64015/ --- Review request for Aurora, Jordan Ly and Kai Huang. Repository: aurora

Re: Review Request 63884: Add RemoveJobUpdates log Op, slim JobUpdateStore API

2017-11-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63884/ --- (Updated Nov. 21, 2017, 3:44 p.m.) Review request for Aurora, Jordan Ly and

Re: Review Request 63884: Idempotent Ops and slimmed API for JobUpdateStore

2017-11-21 Thread Bill Farner
> On Nov. 21, 2017, 9:57 a.m., Stephan Erb wrote: > > I am not completely through but have a first set of comments. > > > > While reviewing this PR I got confused for second in `PruningModule.java`: > > Please notice the difference between `HistoryPrunnerSettings` vs > >

Re: Review Request 63884: Idempotent Ops and slimmed API for JobUpdateStore

2017-11-21 Thread Bill Farner
> On Nov. 21, 2017, 10:53 a.m., David McLaughlin wrote: > > Are we sure this was purely a database optimization? This looks like it > > will now write the entire JobUpdateDetails to the replicated log for every > > instance event change? In large clusters this could impact write log write > >

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review191666 --- Ship it! LGTM. Great new feature! RELEASE-NOTES.md Lines

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread David McLaughlin
> On Nov. 21, 2017, 5:54 p.m., David McLaughlin wrote: > > The outstanding feedback is: > > > > * Discussion on using a mock with capture (my preference) vs using a fake > > implementation. > > * Concern over how to handle a partition during a transient state. My > > preference is to move

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread Bill Farner
> On Nov. 21, 2017, 9:54 a.m., David McLaughlin wrote: > > The outstanding feedback is: > > > > * Discussion on using a mock with capture (my preference) vs using a fake > > implementation. > > * Concern over how to handle a partition during a transient state. My > > preference is to move

Re: Review Request 63973: Enable custom offer scoring modules for task assignment and injecting of custom OfferManagers

2017-11-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191644 --- This looks great to me overall. The issue of custom modules is

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review191626 --- Ship it! Master (46b1112) is green with this patch.

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread Jordan Ly
> On Nov. 21, 2017, 5:54 p.m., David McLaughlin wrote: > > The outstanding feedback is: > > > > * Discussion on using a mock with capture (my preference) vs using a fake > > implementation. > > * Concern over how to handle a partition during a transient state. My > > preference is to move

Re: Review Request 63884: Idempotent Ops and slimmed API for JobUpdateStore

2017-11-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63884/#review191621 --- Are we sure this was purely a database optimization? This looks

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/ --- (Updated Nov. 21, 2017, 6:42 p.m.) Review request for Aurora, Jordan Ly,

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review191616 --- Ship it! Master (46b1112) is green with this patch.

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/ --- (Updated Nov. 21, 2017, 6:18 p.m.) Review request for Aurora, Jordan Ly,

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review191608 --- Master (46b1112) is red with this patch.

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread Stephan Erb
> On Nov. 21, 2017, 6:54 p.m., David McLaughlin wrote: > > The outstanding feedback is: > > > > * Discussion on using a mock with capture (my preference) vs using a fake > > implementation. > > * Concern over how to handle a partition during a transient state. My > > preference is to move

Re: Review Request 63884: Idempotent Ops and slimmed API for JobUpdateStore

2017-11-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63884/#review191592 --- I am not completely through but have a first set of comments.

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review191603 --- The outstanding feedback is: * Discussion on using a mock with

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread David McLaughlin
> On Nov. 16, 2017, 10:01 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java > > Lines 185 (patched) > > > > > > Nit: `isPartitionAware` to minutely

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/ --- (Updated Nov. 21, 2017, 5:50 p.m.) Review request for Aurora, Jordan Ly,

Re: Review Request 63884: Idempotent Ops and slimmed API for JobUpdateStore

2017-11-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63884/#review191580 --- Ping - Bill Farner On Nov. 16, 2017, 10:20 a.m., Bill Farner