Re: Review Request 64290: WIP: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review192672 --- Master (89338dd) is red with this patch.

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

> On Sept. 26, 2017, 5:53 p.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years

Re: Review Request 63750: pants for high-sierra

> On Nov. 14, 2017, 5:13 p.m., Aurora ReviewBot wrote: > > Master (4fecf1f) is red with this patch. > > ./build-support/jenkins/build.sh > > > > WARN] > >

Review Request 64290: WIP: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/ --- Review request for Aurora, Stephan Erb and Bill Farner. Repository: aurora

Re: Review Request 64287: Clean up some lint rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64287/#review192668 --- Ship it! Ship It! - Stephan Erb On Dez. 4, 2017, 12:39

Re: Review Request 64288: Add a SQL persistence implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64288/#review192666 --- Do we have any idea how this performs at scale? I'd like to avoid

Re: Review Request 64287: Clean up some lint rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64287/#review192665 --- Ship it! Ship It! - David McLaughlin On Dec. 3, 2017, 11:39

Re: Review Request 64288: Add a SQL persistence implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64288/#review192664 --- Ship it! Master (89338dd) is green with this patch.

Re: Review Request 64288: Add a SQL persistence implementation

> On Dec. 3, 2017, 5:22 p.m., Santhosh Kumar Shanmugham wrote: > > Can you list the details that will benefit us for pikcing HikariCP? Beyond what i wrote in the description, minimal dependencies (just slf4j) was the biggest. The benchmarks look favorable (and compare to the options i chose

Re: Review Request 64288: Add a SQL persistence implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64288/#review192662 --- Can you list the details that will benefit us for pikcing

Review Request 64288: Add a SQL persistence implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64288/ --- Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.

Re: Review Request 63750: pants for high-sierra

> On Nov. 14, 2017, 4:13 p.m., Aurora ReviewBot wrote: > > Master (4fecf1f) is red with this patch. > > ./build-support/jenkins/build.sh > > > > WARN] > >

Re: Review Request 63750: pants for high-sierra

> On Nov. 14, 2017, 5:13 p.m., Aurora ReviewBot wrote: > > Master (4fecf1f) is red with this patch. > > ./build-support/jenkins/build.sh > > > > WARN] > >

Re: Review Request 64287: Clean up some lint rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64287/#review192659 --- Ship it! Master (89338dd) is green with this patch.

Review Request 64287: Clean up some lint rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64287/ --- Review request for Aurora and Stephan Erb. Repository: aurora Description

Re: Review Request 63750: pants for high-sierra

> On Nov. 15, 2017, 1:13 a.m., Aurora ReviewBot wrote: > > Master (4fecf1f) is red with this patch. > > ./build-support/jenkins/build.sh > > > > WARN] > >

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/#review192648 --- Master (89338dd) is red with this patch.

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

> On Sept. 27, 2017, 1:53 a.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/ --- (Updated Dec. 3, 2017, 9:09 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 64284: Expose thrift workload stats on pruneTasks() invocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64284/#review192646 --- Ship it! Ship It! - Bill Farner On Dec. 3, 2017, 5:20 a.m.,

Re: Review Request 64284: Expose thrift workload stats on pruneTasks() invocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64284/#review192645 --- Ship it! Ship It! - Stephan Erb On Dez. 3, 2017, 2:20

Re: Review Request 64284: Expose thrift workload stats on pruneTasks() invocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64284/#review192644 --- Ship it! Master (cea43db) is green with this patch.

Review Request 64284: Expose thrift workload stats on pruneTasks() invocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64284/ --- Review request for Aurora, Mehrdad Nurolahzade and Stephan Erb. Bugs:

Re: Review Request 64283: Remove redundant transaction recorder

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64283/#review192643 --- Ship it! Ship It! - Stephan Erb On Dez. 3, 2017, 6:53