Re: Review Request 64359: Fix for multiple slf4j jars in intellij

2017-12-05 Thread Bill Farner
> On Dec. 5, 2017, 8:38 p.m., Jordan Ly wrote: > > build.gradle > > Lines 120 (patched) > > > > > > is this used? It is. Since we're now strict about dependency versions in the test classpath, we'll have to force

Re: Review Request 64359: Fix for multiple slf4j jars in intellij

2017-12-05 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64359/#review192965 --- Ship it! One small question but LGTM. build.gradle Lines 120

Review Request 64359: Fix for multiple slf4j jars in intellij

2017-12-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64359/ --- Review request for Aurora and Jordan Ly. Repository: aurora Description

Re: Review Request 64290: WIP: Update to Thrift 0.10.0

2017-12-05 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review192929 --- I've got the needed fix out here:

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review192889 --- Thanks for the patch! RELEASE-NOTES.md Lines 50 (patched)

Re: Review Request 64286: Recover snapshots via the Op stream

2017-12-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64286/#review192892 --- Ship it! Master (a0628ef) is green with this patch.

Re: Review Request 64286: Recover snapshots via the Op stream

2017-12-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64286/#review192888 --- Reviewer notes.

Review Request 64286: Recover snapshots via the Op stream

2017-12-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64286/ --- Review request for Aurora, Jordan Ly and Stephan Erb. Repository: aurora

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review192878 --- Ship it! Master (a0628ef) is green with this patch.

Review Request 64341: Add metadata field to Job object in DSL

2017-12-05 Thread Jing Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/ --- Review request for Aurora, David McLaughlin, Stephan Erb, and Bill Farner.