Re: Review Request 64519: Add a test to detect incompatible storage changes

2017-12-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64519/#review193977 --- Ship it! Master (2e1ca42) is green with this patch.

Re: Review Request 64519: Add a test to detect incompatible storage changes

2017-12-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64519/#review193974 --- Master (2e1ca42) is red with this patch.

Re: Review Request 64625: Add a storage recovery tool

2017-12-15 Thread Bill Farner
> On Dec. 15, 2017, 10:02 a.m., Reza Motamedi wrote: > > I really like the test. > > > > I wonder if it makes sense to add something to doc re how to use this. > > Although the test clearly shows that. > docs I agree, release notes are also necessary. I will add these in a follow-up. -

Re: Review Request 64629: Use java.util.Optional throughout

2017-12-15 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64629/#review193946 --- Ship it! Ship It! - Jordan Ly On Dec. 14, 2017, 11:09 p.m.,

Re: Review Request 64625: Add a storage recovery tool

2017-12-15 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64625/#review193943 --- Ship it! I really like the test. I wonder if it makes sense

Re: Review Request 64625: Add a storage recovery tool

2017-12-15 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64625/#review193940 --- Ship it! LGTM! Good tests, super excited about this. - Jordan