--
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54107/
> -------
>
> (Updated Nov. 30, 2016, 6:14 a.m.)
>
>
> Review request for
-mail. To reply, visit:
> https://reviews.apache.org/r/54107/
> ---
>
> (Updated Dec. 1, 2016, 8:39 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, Mehrdad
> Nurolahzade, and Santhosh Kumar Shanmug
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54107/
> -------
>
> (Updated Dec. 1, 2016, 8:39 p.m.)
>
>
> Review reques
stic way that appending the noop transaction could take
> > longer than creating/persisting the snapshot (in which case the snapshot
> > could be successfully persisted referencing that position, yet that
> > position would not exist in the operation log).
>
> David McLaughlin wr
/SnapshotStoreImpl.java
239f2eb475bec20acfcc2990d5d933f5bec83ed4
Diff: https://reviews.apache.org/r/54847/diff/
Testing
---
Thanks,
David McLaughlin
/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java
239f2eb475bec20acfcc2990d5d933f5bec83ed4
Diff: https://reviews.apache.org/r/54847/diff/
Testing
---
Thanks,
David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55003/#review160043
---
Ship it!
Ship It!
- David McLaughlin
On Dec. 23, 2016, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54990/#review160058
---
Ship it!
Ship It!
- David McLaughlin
On Dec. 22, 2016, 7:27
> On Dec. 23, 2016, 10:07 a.m., David McLaughlin wrote:
> > Ship It!
This has been merged to master.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54990/#rev
> On Dec. 23, 2016, 8:10 a.m., David McLaughlin wrote:
> > Ship It!
This has been merged to master.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55003/#rev
> On Dec. 22, 2016, 10:54 a.m., David McLaughlin wrote:
> > Ship It!
This has been merged to master.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54959/#rev
erface) did a good
job with the abstractions there.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54883/#review160165
-------
On Dec
t incremented in this fashion?
No, they are opaque references. Position is an empty interface, not a long. See
the reply to Stephan above.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://revi
ge state as applying it once, then appending a noop is
not needed.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54883/#review160184
-------
c/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java
(lines 97 - 98)
<https://reviews.apache.org/r/54959/#comment230970>
Inline?
- David McLaughlin
On Dec. 22, 2016, 1:11 a.m., Mehrdad Nurol
cluster.
- David McLaughlin
On Dec. 22, 2016, 12:06 a.m., Karthik Anantha Padmanabhan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
: 0, locks: 0, quota confs: 0, tasks: 0, updates: 0
Thanks,
David McLaughlin
: 0, updates: 0
Thanks,
David McLaughlin
:18:36.605798 4160 replica.cpp:697] Replica learned TRUNCATE action at
position 7
I1222 07:18:36.605 [pool-12-thread-1, LogStorage] Snapshot complete. host
attrs: 1, cron jobs: 0, locks: 0, quota confs: 0, tasks: 0, updates: 0
Thanks,
David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54959/#review159944
---
Ship it!
Ship It!
- David McLaughlin
On Dec. 22, 2016, 6:49
/VersionedMesosSchedulerImpl.java
Lines 168 (patched)
<https://reviews.apache.org/r/58053/#comment243546>
Since it has to be true to execute this code block, isn't this redundant?
- David McLaughlin
On March 30, 2017, 6:37 p.m., Zameer Manji
? It seems like this implementation is not
future proof at all.
- David McLaughlin
On March 30, 2017, 11:20 p.m., Dmitriy Shirchenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
)
<https://reviews.apache.org/r/54957/#comment242595>
Where is options.no_retry defined?
- David McLaughlin
On March 23, 2017, 4:23 p.m., Karthik Anantha Padmanabhan wrote:
>
> ---
> This is an automatically generated e
> On March 30, 2017, 11:56 p.m., David McLaughlin wrote:
> > The motivation for this is a performance optimization (less Scheduling loop
> > overhead + cache locality on the target host). So why should that decision
> > be encoded in the service tier? We'd want ev
://reviews.apache.org/r/58259/diff/1/
Testing
---
./gradlew build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
David McLaughlin
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
David McLaughlin
the stack trace. Run with --info or
> > --debug option to get more log output.
> >
> > BUILD FAILED
> >
> > Total time: 2 mins 59.074 secs
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
@ReviewBot retry
- David
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58524/#review172348
---
Ship it!
Ship It!
- David McLaughlin
On April 19, 2017, 9
>
> (Updated Oct. 11, 2016, 6:17 p.m.)
>
>
> Review request for Aurora, David McLaughlin, John Sirois, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This experiment is inspired by David's comment: "I don’t t
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58259/#review172099
---
@ReviewBot retry
- David McLaughlin
On April 12, 2017, 7:51
ora and cannot be intercepted by
> > another framework?
> >
> > Please run `./gradlew jmh -Pbenchmarks='SchedulingBenchmarks.*'` to help
> > ensure the scheduling changes don't come with an unexpected performance
> > regression.
>
> David McLaughlin wr
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58259/#review172324
---
On April 12, 2017, 7:51 a.m., David McLaughlin wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57404/#review168323
---
Ship it!
Ship It!
- David McLaughlin
On March 8, 2017, 2:05
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58053/#review170720
---
Ship it!
Ship It!
- David McLaughlin
On March 31, 2017, 12
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58259/#review172122
---
On April 12, 2017, 7:51 a.m., David M
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58651/#review172800
---
Ship it!
Ship It!
- David McLaughlin
On April 23, 2017, 11
> On Aug. 2, 2017, 8:38 p.m., David McLaughlin wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java
> > Lines 266 (patched)
> > <https://reviews.apache.org/r/61249/diff/1/?file=1785805#file1785805line266>
> >
> > Th
this patch landed, and
below it will default to "GMT", possibly conflicting with the scheduler
default.
So you can either do a null check here and call predictNextRun when it's
null, or do a storage backfill and add timezone to all existing crons.
- David McLaughlin
On Ju
> On Aug. 2, 2017, 8:38 p.m., David McLaughlin wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java
> > Lines 266 (patched)
> > <https://reviews.apache.org/r/61249/diff/1/?file=1785805#file1785805line266>
> >
> > Th
> On Aug. 2, 2017, 8:38 p.m., David McLaughlin wrote:
> > api/src/main/thrift/org/apache/aurora/gen/api.thrift
> > Lines 328 (patched)
> > <https://reviews.apache.org/r/61249/diff/1/?file=1785797#file1785797line328>
> >
> > Needs to be marked option
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60714/#review180637
---
Ship it!
Ship It!
- David McLaughlin
On July 7, 2017, 11:52
deployed it to
production. We are seeing more tasks lost due to being launched in invalid
offers.
I think we should revert this change until we root cause it.
- David McLaughlin
On June 6, 2017, 8:56 p.m., Zameer Manji wrote
> On June 28, 2017, 5:22 p.m., David McLaughlin wrote:
> > This change appears to have caused adverse behavior when we deployed it to
> > production. We are seeing more tasks lost due to being launched in invalid
> > offers.
> >
> > I think we should rever
> On April 26, 2017, 1:20 a.m., David McLaughlin wrote:
> > How is the affect of changes like this measured? Seems very hunch-driven,
> > whereas other potential performance reviews were met with requests for
> > methodology, etc.
>
> David McLaughlin wrote:
>
> On April 26, 2017, 1:20 a.m., David McLaughlin wrote:
> > How is the affect of changes like this measured? Seems very hunch-driven,
> > whereas other potential performance reviews were met with requests for
> > methodology, etc.
Also, generally good to have at least tw
-driven,
whereas other potential performance reviews were met with requests for
methodology, etc.
- David McLaughlin
On April 21, 2017, 10:36 a.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To rep
/SchedulerThriftInterface.java
Lines 312-325 (patched)
<https://reviews.apache.org/r/58768/#comment246224>
This method checks if the job already exists before executing this code? So
this would only ever be true if there was a race condition with another request.
- David McLaughlin
On April 26, 20
> On April 27, 2017, 12:44 a.m., David McLaughlin wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
> > Lines 312-325 (patched)
> > <https://reviews.apache.org/r/58768/diff/1/?file=1700804#file1700804line312>
> >
>
a name of the cache (preemption_slot_cache) and
then add the suffixes.
- David McLaughlin
On April 24, 2017, 9:38 p.m., Reza Motamedi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
-435a-a3d9-2b54f6eac3fa__consistent-offer-rate.png
Async task workload (scaled) correlation with degraded cache utilization
https://reviews.apache.org/media/uploaded/files/2017/04/25/7eaf37ac-fbf3-40eb-b3f6-90e914a3936f__async-task-correlation.png
Thanks,
David McLaughlin
was readily available.
Next steps are to confirm and address the task history pruning issue.
- David McLaughlin
On April 12, 2017, 7:51 a.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
> -------
>
> (Updated April 21, 2017, 11:34 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, and
> Santhosh Kumar.
>
>
> Repository: aurora
>
>
> Description
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58636/#review172930
---
Ship it!
Ship It!
- David McLaughlin
On April 24, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61238/#review181754
---
Ship it!
Ship It!
- David McLaughlin
On July 29, 2017, 2:30
---
On Aug. 22, 2017, 5:05 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61804/
> -------
>
> (Up
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61804/#review183514
---
Ship it!
Ship It!
- David McLaughlin
On Aug. 22, 2017, 5:05
-bb93011407af__Screen_Shot_2017-05-01_at_6.30.18_PM.png
JobUpdateControllerImpl bottleneck
https://reviews.apache.org/media/uploaded/files/2017/05/02/f93484bd-c99e-4c01-9f8a-f0ad867adb26__Screen_Shot_2017-05-02_at_3.33.39_PM.png
Thanks,
David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58850/#review173550
---
Ship it!
Ship It!
- David McLaughlin
On April 28, 2017, 10
> On April 25, 2017, 3:01 a.m., David McLaughlin wrote:
> > We have complete initial scale testing of this patch with updates spanning
> > 10 to 10k instances across 10k agents. Here are the findings:
> >
> > 1) The patch works great for small and medium sized update
-01_at_6.30.18_PM.png
Thanks,
David McLaughlin
ly generated e-mail. To reply, visit:
https://reviews.apache.org/r/58768/#review173237
---
On May 3, 2017, 4:33 a.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To rep
/TaskGroups.java
cea8d0f0795acfd3bbe2f1ee120ec047eee34e0f
Diff: https://reviews.apache.org/r/58922/diff/2/
Changes: https://reviews.apache.org/r/58922/diff/1-2/
Testing
---
N/A
Thanks,
David McLaughlin
://reviews.apache.org/r/58922/diff/1/
Testing
---
N/A
Thanks,
David McLaughlin
cea8d0f0795acfd3bbe2f1ee120ec047eee34e0f
Diff: https://reviews.apache.org/r/58922/diff/1/
Testing
---
N/A
Thanks,
David McLaughlin
Thanks,
David McLaughlin
/files/2017/05/02/f93484bd-c99e-4c01-9f8a-f0ad867adb26__Screen_Shot_2017-05-02_at_3.33.39_PM.png
Thanks,
David McLaughlin
JobUpdateControllerImpl bottleneck
https://reviews.apache.org/media/uploaded/files/2017/05/02/f93484bd-c99e-4c01-9f8a-f0ad867adb26__Screen_Shot_2017-05-02_at_3.33.39_PM.png
Thanks,
David McLaughlin
bash tricks, for instance what happens
> > if the user set a path that has `~` or `../../../` to go up the dir chain.
>
> David McLaughlin wrote:
> I think it's fine to delegate that to the scp command, no? If they have
> the permissions to copy stuff outside of their co
On May 11, 2017, 5:13 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> ---
>
> (Updated May 11, 2017, 5:13 p.m.)
>
>
> Review
ically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174694
-------
On May 11, 2017, 5:13 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
like:
https://gist.github.com/DavidMcLaughlin/5d5472cde15343aef8705478f644ddb9
Thanks,
David McLaughlin
/client/cli/test_task.py
Lines 322 (patched)
<https://reviews.apache.org/r/59163/#comment248805>
Use of magic strings from the unit under test here. Extract to constants
and reuse them here (eg. ScpCommand.TILDE_USAGE_ERROR_MSG).
- David McLaughlin
On May 18, 2017, 6:12 a.m., Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59231/#review174815
---
Ship it!
Ship It!
- David McLaughlin
On May 12, 2017, 4:48
Thanks,
David McLaughlin
d here.
Suggest refactoring the module with a constructor that accepts a
WebhookInfo in order to achieve the desired testability.
- David McLaughlin
On June 9, 2017, 5:13 a.m., Kai Huang wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177655
---
Ship it!
Ship It!
- David McLaughlin
On June 8, 2017, 7:25
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59733/#review177659
---
Ship it!
Ship It!
- David McLaughlin
On June 12, 2017, 6:37
/main/python/apache/thermos/monitoring/resource.py
Line 160 (original), 166 (patched)
<https://reviews.apache.org/r/60354/#comment252861>
I think better variable names would help with reading this code.
- David McLaughlin
On June 22, 2017, 3:28 p.m., Reza Motamedi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60350/#review178709
---
Ship it!
Ship It!
- David McLaughlin
On June 22, 2017, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60437/#review178912
---
Ship it!
Ship It!
- David McLaughlin
On June 26, 2017, 5:37
he benchmarks and alerts if they stop working (or if there's a major
> regression in terms of perf)?
>
> Stephan Erb wrote:
> Good idea! We might need some tweaking of the benchmark footprint but
> that should be feasible.
>
> David McLaughlin wrote:
> Do the Scheduli
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59039/#review174790
---
On May 11, 2017, 9:46 p.m., David McLaughlin wrote:
>
> --
-Pbenchmarks='SchedulingBenchmarks.*'
Thanks,
David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59495/#review175853
---
Ship it!
Ship It!
- David McLaughlin
On May 23, 2017, 9:09
,
David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59480/#review175977
---
On May 23, 2017, 7:41 a.m., David McLaughlin wrote:
>
> ---
&g
workload by increasing
number of replicas, etc.
- David
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59480/#review176057
clusters to plug in a custom task
assigner. We were able to remove our modifications to the OSS code-base and use
this mechanism to do what we need. Here is a rough gist of what it looks like:
https://gist.github.com/DavidMcLaughlin/5d5472cde15343aef8705478f644ddb9
Thanks,
David McLaughlin
wrote:
> Not directly related here, but should we add something that regularly
> runs the benchmarks and alerts if they stop working (or if there's a major
> regression in terms of perf)?
>
> Stephan Erb wrote:
> Good idea! We might need some tweaking of the benchmark footp
n.md
Done.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59039/#review174762
---
On May 25, 2017, 5:50 a.m., D
, this is where the extra seconds
are spent. This could be reduced by just jumping over all the offers we know to
be too small, but that decision has to map to the OfferOrder (which adds
complexity). That can be addressed in a follow-up review if needed.
Thanks,
David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59417/#review176314
---
Ship it!
Ship It!
- David McLaughlin
On May 19, 2017, 8:33
> On June 1, 2017, 10:46 p.m., David McLaughlin wrote:
> > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java
> > Line 376 (original), 377 (patched)
> > <https://reviews.apache.org/r/59699/diff/3/?file=1739138#file1739138line379>
> >
> >
37 (patched)
<https://reviews.apache.org/r/59733/#comment250135>
Will this break for tasks that were deployed before the client was updated?
Should we also inject a default here?
- David McLaughlin
On June 1, 2017, 11:48 p.m., Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59699/#review176716
---
Ship it!
Ship It!
- David McLaughlin
On June 2, 2017, 12:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59640/#review176452
---
Ship it!
Ship It!
- David McLaughlin
On May 30, 2017, 9:21
gt;
> > REVOCABLE_MEMORY is missing in this switch statement.
Removed REVOCABLE_MEMORY entirely.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59480/#review176
in the coalesce
method? And show before/after results using the scale test?
- David McLaughlin
On June 1, 2017, 12:18 a.m., Kai Huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
eduler/state/StateManagerImpl.java#L371
And then remove the taskStore.deleteTasks from the PubsubEvent factory
method (have no idea why it's in there).
- David McLaughlin
On June 1, 2017, 12:18 a.m., Kai Huang
: https://reviews.apache.org/r/59698/diff/1/
Testing
---
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
David McLaughlin
101 - 200 of 519 matches
Mail list logo
