/scheduler/updater/InstanceUpdaterTest.java
c78c7fbd7d600586136863c99ce3d7387895efee
Diff: https://reviews.apache.org/r/51536/diff/
Testing
---
./gradlew build
./gradlew :test --tests
"org.apache.aurora.scheduler.updater.InstanceUpdaterTest"
./build-support/jenkins/build.sh
Th
g occurs.
> >
> > We now support shell healthchecking, so a job may not have any port
> > named health but it will still have it's health checked by thermos.
> >
> > Why can't enabling of this feature be a property of the Job or Update?
>
> Ka
, visit:
https://reviews.apache.org/r/51536/#review147599
-------
On Sept. 2, 2016, 3:55 p.m., Kai Huang wrote:
>
> ---
> This is an automatically gener
org/r/51580/diff/
>
>
> Testing
> ---
>
> ./gradlew build
>
> ./gradlew :test --tests
> "org.apache.aurora.scheduler.updater.InstanceUpdaterTest"
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Kai Huang
>
>
/build.sh
Thanks,
Kai Huang
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147730
-------
On Sept. 5, 2016, 6:56 p.m., Kai Huang wrote:
>
> ---
> This is an
: https://reviews.apache.org/r/51536/diff/
Testing (updated)
---
./gradlew build
./gradlew :test --tests "org.apache.aurora.scheduler.updater.JobUpdaterIT"
./build-support/jenkins/build.sh
Thanks,
Kai Huang
scheduler -> executor ->
client.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/#review147917
----------
90ea3a169dadc72e7d7493544ab865ec59d4d425
Diff: https://reviews.apache.org/r/51580/diff/
Testing
---
./gradlew build
./gradlew :test --tests
"org.apache.aurora.scheduler.updater.InstanceUpdaterTest"
./build-support/jenkins/build.sh
Thanks,
Kai Huang
rTest"
./build-support/jenkins/build.sh
Thanks,
Kai Huang
/diff/
Testing
---
./gradlew build
./gradlew :test --tests
"org.apache.aurora.scheduler.updater.InstanceUpdaterTest"
Thanks,
Kai Huang
"org.apache.aurora.scheduler.updater.JobUpdaterIT"
./build-support/jenkins/build.sh
Thanks,
Kai Huang
.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/#review148075
---
On Sept. 6, 2016, 6:46 p.m., Kai Hu
/51536/diff/
Testing
---
./gradlew build
./gradlew :test --tests "org.apache.aurora.scheduler.updater.JobUpdaterIT"
./build-support/jenkins/build.sh
Thanks,
Kai Huang
://reviews.apache.org/r/51536/diff/
Testing
---
./gradlew build
./gradlew :test --tests "org.apache.aurora.scheduler.updater.JobUpdaterIT"
./build-support/jenkins/build.sh
Thanks,
Kai Huang
build
./gradlew :test --tests "org.apache.aurora.scheduler.updater.JobUpdaterIT"
./build-support/jenkins/build.sh
Thanks,
Kai Huang
./gradlew :test --tests "org.apache.aurora.scheduler.updater.JobUpdaterIT"
./build-support/jenkins/build.sh
Thanks,
Kai Huang
ne attribute called "watch_sec_skippable", and send
it to the scheduler.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/#review147358
-------
SUCCEEDED
state, rather than EVALUATE_ON_STATE_CHANGE.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/#review147358
-------
"org.apache.aurora.scheduler.updater.InstanceUpdaterTest"
./build-support/jenkins/build.sh
Thanks,
Kai Huang
/
Testing
---
./gradlew build
./gradlew :test --tests
"org.apache.aurora.scheduler.updater.InstanceUpdaterTest"
./build-support/jenkins/build.sh
Thanks,
Kai Huang
ail. To reply, visit:
https://reviews.apache.org/r/51536/#review147358
-------
On Aug. 30, 2016, 8:52 p.m., Kai Huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51536/
&
of the check interval in tests. See:
https://github.com/apache/aurora/blob/master/src/test/python/apache/aurora/executor/common/test_health_checker.py#L114
I'm thinking about doing the expiration check in a separate thread, and
memoize if initital_interval expires.
- Kai Huang
On Sept. 14, 20
should not
dictate how we write the source code. Sometimes we have to refactor them.
Please feel free to weigh in.
- Kai Huang
On Sept. 14, 2016, 4:43 a.m., Kai Huang wrote:
>
> ---
> This is an automatically generated e-mail.
guess it's OK.
- Kai Huang
On Sept. 8, 2016, 8:07 p.m., Kai Huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
uture reviews to understand the impact of the changes in this review. On
> > top of that, the doubling up of sending the `TASK_RUNNING` update while the
> > code is in the in-between state also makes me nervous.
> >
> > We also definitely need test coverage for this call
uture reviews to understand the impact of the changes in this review. On
> > top of that, the doubling up of sending the `TASK_RUNNING` update while the
> > code is in the in-between state also makes me nervous.
> >
> > We also definitely need test coverage
his callback.
Thanks for the valid feedback. I'll work on them.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51742/#review148258
-
ache/aurora/executor/status_manager.py
228a99a05f339e21cd7e769a42b9b2276e7bc3fc
src/test/python/apache/aurora/executor/test_status_manager.py
ce4679ba1aa7b42cf0115c943d84663030182d23
Diff: https://reviews.apache.org/r/51742/diff/
Testing
---
./gradlew build
./build-support/jenkins/build.sh
Thanks,
Kai Huang
a7b42cf0115c943d84663030182d23
src/test/python/apache/aurora/executor/test_thermos_executor.py
0bfe9e931f873c9f804f2ba4012e050e1f9fd24e
Diff: https://reviews.apache.org/r/51876/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
Thanks,
Kai Huang
-
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
Thanks,
Kai Huang
xecutor/test_status_manager.py
ce4679ba1aa7b42cf0115c943d84663030182d23
src/test/python/apache/aurora/executor/test_thermos_executor.py
0bfe9e931f873c9f804f2ba4012e050e1f9fd24e
Diff: https://reviews.apache.org/r/51876/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
Thanks,
Kai Huang
num? A task that is in the middle of the
> > `initial_interval_secs` timeout technically is still healthy, right? I feel
> > having a boolean `isHealthy` should be enough to cover all possible
> > scenarios as `StatusManager` checks for `isHealthy` AND the task status
> > itself
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review148937
---
On Sept. 14, 2016, 4:43 a.m., Kai Huang wrote
lly generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review150246
-------
On Sept. 23, 2016, 6:58 p.m., Kai Huang wrote:
>
> ---
>
(line 196)
<https://reviews.apache.org/r/51876/#comment218408>
We should export consecutive_successes as well?
- Kai Huang
On Sept. 23, 2016, 6:58 p.m., Kai Huang wrote:
>
> ---
> This is an automatically generated e
r/51876/#review150769
---
On Sept. 28, 2016, 9:07 p.m., Kai Huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
4129b8
Diff: https://reviews.apache.org/r/52453/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Kai Huang
on/health_checker.py
03fbffdc3862a94c2ba42c9b9e8f2be4094129b8
Diff: https://reviews.apache.org/r/52453/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Kai Huang
rora/executor/common/health_checker.py
03fbffdc3862a94c2ba42c9b9e8f2be4094129b8
Diff: https://reviews.apache.org/r/52453/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Kai Huang
be negative."
sure. Will do.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/#review151372
-------
O
ps://reviews.apache.org/r/51876/#review149846
-------
On Sept. 20, 2016, 12:25 a.m., Kai Huang wrote:
>
> ---
> This is an automatically generated e-mail.
(lines 153 -
155)
<https://reviews.apache.org/r/51876/#comment217593>
A typo here, it should be:
if NOT self.health_check_passed:
log.warning....
- Kai Huang
On Sept. 20, 2016, 12:25 a.m., Kai Huang
eviews.apache.org/r/51876/#review149846
-------
On Sept. 20, 2016, 12:25 a.m., Kai Huang wrote:
>
> ---
> This is an automatically generated e-mail. To re
in this way, our test will cover it.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review149859
-------
O
is should be `mesos_pb2.TASK_RUNNING`, right?
Sure, it seems the status was used in a mixed pattern in the code base. I will
refactor all occurrences.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.ap
RUNNING state and `_shutdown()` act as a default callback for anything
> > else? Curious what others think here.
>
> Kai Huang wrote:
> A safer way is to map all mesos_pb2.TaskState to shutdown().
>
> But I think self.TERMINAL_STATES should be sufficient, for the
ted e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review149846
-------
On Sept. 20, 2016, 12:25 a.m., Kai Huang wrote:
>
> ---
> This is an automatically
Runner)
- Set up necessary HealthCheckers
- Set up StatusManager, and attach HealthCheckers
- Kai Huang
On Sept. 23, 2016, 12:57 a.m., Kai Huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
to be refactored to reduce duplication and reuse
> > what's now in `is_health_check_enabled` as much as possible. Ideally, we
> > should have the only place we extract `health_checker` and the like.
>
> Kai Huang wrote:
> The complexity is that the health checker did some
reply, visit:
https://reviews.apache.org/r/52094/#review149719
-------
On Sept. 20, 2016, 7:43 p.m., Kai Huang wrote:
>
> ---
> This is an automatically generated e-mail. T
/python/apache/aurora/executor/test_thermos_executor.py
0bfe9e931f873c9f804f2ba4012e050e1f9fd24e
Diff: https://reviews.apache.org/r/51876/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
Thanks,
Kai Huang
e.org/r/52094/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/client::
./pants test.pytest src/test/python/apache/aurora/config::
Thanks,
Kai Huang
arming up period.
I'm thinking that whether we should incorporate this information as a
client warning message to prevent misuse of the configuration?
I'll wait until Maxim to weigh in. But thanks for your feedback, Dmitriy!
- Kai Huang
On Sept. 23, 2016, 4:34 a.m., Kai Huang
between watch_secs, max_consecutive_failures here.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52094/#review150118
--------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review150200
-------
On Sept. 23, 2016, 12:57 a.m., Kai Huang wrote:
>
> ---
cutor/test_thermos_executor.py
0bfe9e931f873c9f804f2ba4012e050e1f9fd24e
Diff: https://reviews.apache.org/r/51876/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
Thanks,
Kai Huang
eftover?
will remove it.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review149846
---
On Sept. 20,
bcb73136fa7eb
Diff: https://reviews.apache.org/r/52094/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/client::
./pants test.pytest src/test/python/apache/aurora/config::
Thanks,
Kai Huang
ff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
Thanks,
Kai Huang
(line 104)
<https://reviews.apache.org/r/51876/#comment217227>
Use TaskState.Value('TASK_RUNNING') here instead of mesos_pb2.TASK_RUNNING,
because this file also used TaskState in multiple places.
- Kai Huang
On Sept. 20, 2016, 12:25 a.m., Kai Huang
873c9f804f2ba4012e050e1f9fd24e
Diff: https://reviews.apache.org/r/51876/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
Thanks,
Kai Huang
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/client::
./pants test.pytest src/test/python/apache/aurora/config::
Thanks,
Kai Huang
0453c0bcb73136fa7eb
Diff: https://reviews.apache.org/r/52094/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/client::
./pants test.pytest src/test/python/apache/aurora/config::
Thanks,
Kai Huang
its
> > `reason`. To reduce duplication you should use that instead.
Thanks, will fix it.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review150612
-------
ache/aurora/client/test_config.py
5cf68a5145ddf9478baa30453c0bcb73136fa7eb
Diff: https://reviews.apache.org/r/52094/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/client::
./pants test.pytest src/test/python/apache/aurora/config::
Thanks,
Kai Huang
cutor/test_thermos_executor.py
0bfe9e931f873c9f804f2ba4012e050e1f9fd24e
Diff: https://reviews.apache.org/r/51876/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
Thanks,
Kai Huang
cally generated e-mail. To reply, visit:
https://reviews.apache.org/r/51876/#review151029
---
On Sept. 29, 2016, 11:11 p.m., Kai Huang wrote:
>
> ---
> This is an automa
4129b8
Diff: https://reviews.apache.org/r/52453/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Kai Huang
on/health_checker.py
03fbffdc3862a94c2ba42c9b9e8f2be4094129b8
Diff: https://reviews.apache.org/r/52453/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Kai Huang
> On Sept. 28, 2016, 9:52 p.m., Joshua Cohen wrote:
> > I tried to commit this, but e2e tests hung for me.
> >
> > Kai, can you investigate?
>
> Kai Huang wrote:
> There is a bug of thermos kill for task running in docker
> container(https://issues.a
d.sh
./pants test.pytest src/test/python/apache/aurora/client::
./pants test.pytest src/test/python/apache/aurora/config::
Thanks,
Kai Huang
cutor/test_thermos_executor.py
0bfe9e931f873c9f804f2ba4012e050e1f9fd24e
Diff: https://reviews.apache.org/r/51876/diff/
Testing
---
./build-support/jenkins/build.sh
./pants test.pytest src/test/python/apache/aurora/executor::
Thanks,
Kai Huang
ache/aurora/executor/aurora_executor.py#L120),
and exacerbated by the --coverage flag.
I was wondering if we should just proceed and ignore the warning or be more
precautious and revisit executor change?
- Kai Huang
On Oct. 4, 2016, 12:42 a
> On Oct. 4, 2016, 6:36 a.m., Kai Huang wrote:
> > I noticed that AuroraBot says the test is green but some coverage are
> > missing...
> >
> > When I test the code locally, the code passes pants tests and style check
> > in:
> > ./build-support/j
_Screen_Shot_2016-10-11_at_6.17.00_PM.png
Thanks,
Kai Huang
.
File Attachments
Task with default Health Check Config
https://reviews.apache.org/media/uploaded/files/2016/10/12/64cf6610-9294-46cb-b159-6e5721da5fff__Screen_Shot_2016-10-11_at_6.17.00_PM.png
Thanks,
Kai Huang
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52766/#review152252
---
On Oct. 12, 2016, 5:01 a.m., Kai Huang wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52806/#review152411
---
Ship it!
Ship It!
- Kai Huang
On Oct. 12, 2016, 9:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54967/#review160828
---
Ship it!
lgtm!
- Kai Huang
On Dec. 22, 2016, 7:37 a.m
/SnapshotStoreImpl.java
(line 521)
<https://reviews.apache.org/r/55105/#comment231657>
If we need this elsewhere, can we make the timing part more reusable like:
Stats.time("statsName", () -> {#function to time})
- Kai Huang
On Dec. 30, 2016, 9:18 p.m., Mehrda
/SlidingStatsTest.java
(line 48)
<https://reviews.apache.org/r/55105/#comment232119>
Can we add a clock for SlidingStats like
https://reviews.apache.org/r/54967/, so that we can use a Fake clock to test if
the elapsed time was accumulated correctly?
- Kai Huang
On Jan. 5, 2017, 4:36 a.m., M
i, retrying...
INFO] Instance 0 has been up and healthy for at least 30 seconds
INFO] All instances were restarted successfully
Job devcluster/vagrant/test/hello restarted successfully
```
Thanks,
Kai Huang
error communicating with scheduler: Timed out talking to
http://aurora.local:8081/api, retrying...
INFO] Instance 0 has been up and healthy for at least 30 seconds
INFO] All instances were restarted successfully
Job devcluster/vagrant/test/hello restarted successfully
```
Thanks,
Kai Huang
r/vagrant/test/hello restarted successfully
```
Thanks,
Kai Huang
error communicating with scheduler during non-idempotent operation:
Timed out talking to http://aurora.local:8081/api, not retrying
```
Thanks,
Kai Huang
statuses: LOST, FAILED, they can
provide them in the whitelist:
The user can also match all TaskStateChange statuses using a wildcard character
"*" in webhook.json like below:
```
{
"headers": {
"Content-Type": "application/vnd.kafka.json.v1+json",
ication/vnd.kafka.json.v1+json",
"Producer-Type": "reliable"
},
"targetURL": "http://localhost:5000/;,
"timeoutMsec": 50,
"statuses": ["LOST", "FAILED"]
}
```
Thanks,
Kai Huang
Diff: https://reviews.apache.org/r/60350/diff/1/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Kai Huang
Thanks,
Kai Huang
tasks.
- After applying the patch, the pruning takes ~1 minute.
File Attachments
task_history_pruning_benchmark.png
https://reviews.apache.org/media/uploaded/files/2017/06/01/74eb5104-d338-4530-abd2-b82fbdc6bf84__task_history_pruning_benchmark.png
Thanks,
Kai Huang
task_history_pruning_benchmark.png
https://reviews.apache.org/media/uploaded/files/2017/06/01/74eb5104-d338-4530-abd2-b82fbdc6bf84__task_history_pruning_benchmark.png
Thanks,
Kai Huang
reply, visit:
https://reviews.apache.org/r/59699/#review176694
-------
On June 1, 2017, 10:41 p.m., Kai Huang wrote:
>
> ---
> This is an automatically
ore.deleteTasks.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59699/#review176567
---
On June 1, 2017, 12:18 a.m., Kai Huang wrot
runing.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59699/#review176568
---
On June 1, 2017, 12:18 a.m.,
te/StateManagerImpl.java#L371
> >
> > And then remove the taskStore.deleteTasks from the PubsubEvent factory
> > method (have no idea why it's in there).
>
> Kai Huang wrote:
> Moving the taskStore.deleteTasks out will break some other oper
-
src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java
73878210f9028901fda3b08e66c6a63c24260d35
Diff: https://reviews.apache.org/r/59699/diff/1/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Kai Huang
te/StateManagerImpl.java#L371
> >
> > And then remove the taskStore.deleteTasks from the PubsubEvent factory
> > method (have no idea why it's in there).
>
> Kai Huang wrote:
> Moving the taskStore.deleteTasks out will break some other oper
all task deletions.
- Kai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59699/#review176716
---
On June 2, 2017, 12:01 a.m., Kai Hu
t;
> > We probably don't even need the separate events. We could just have:
> >
> > eventSink.post(createDeleteEvent(taskStore, taskIds));
>
> Kai Huang wrote:
> So this will change the semantics that: The Delete Event is published
> after we delete
1 - 100 of 149 matches
Mail list logo
