Re: Review Request 36785: Add retroactive NEWS entry for 0.8.0.

2015-07-24 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36785/#review92948 --- Ship it! Ship It! - Steve Niemitz On July 24, 2015, 6 p.m

Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-26 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37801/#review96560 --- On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote

Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-26 Thread Steve Niemitz
. Steve Niemitz wrote: Is there a good way to test this other than something gross like: str(String({{mesos.hostname}}).bind(*instance.scopes())). Here the hostname is in the binding context but not on any inspectable field on the instance itself. nm, I figured out a good test here. I'll

Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-26 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37801/#review96565 --- On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote

Re: Review Request 37801: Added support for {{mesos.hostname}} in aur files

2015-08-26 Thread Steve Niemitz
/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31 Diff: https://reviews.apache.org/r/37801/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 40889: Changed mesos native lib to use mesos.executor instead

2015-12-03 Thread Steve Niemitz
To reply, visit: https://reviews.apache.org/r/40889/#review108758 ------- On Dec. 2, 2015, 11:57 p.m., Steve Niemitz wrote: > > --- > This is an automatica

Re: Review Request 40889: Changed mesos native lib to use mesos.executor instead

2015-12-07 Thread Steve Niemitz
ge, as it can't land until some changes go into mesos. I think Steve is > not expecting ship-its just yet. > > Steve Niemitz wrote: > Correct, I'll ping when I'm ready for more eyes on it. > > Zameer Manji wrote: > If you do want to do this, please assign >

Re: Review Request 40889: Changed mesos native lib to use mesos.executor instead

2015-12-07 Thread Steve Niemitz
ge, as it can't land until some changes go into mesos. I think Steve is > not expecting ship-its just yet. > > Steve Niemitz wrote: > Correct, I'll ping when I'm ready for more eyes on it. > > Zameer Manji wrote: > If you do want to do this, please assign >

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

2016-03-09 Thread Steve Niemitz
this patch for 6+ months now with no issues. - Steve Niemitz On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread Steve Niemitz
space. However, once my patch lands, the lib goes down to ~8 MB, which I think is worth duplicating, especially to get rid of any weird race conditions with multiple executors launching. - Steve Niemitz On March 28, 2016, 6:21 p.m., George Sirois

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125726 --- Ship it! Ship It! - Steve Niemitz On March 28, 2016, 6:21

Re: Review Request 45392: Reorganize Documentation

2016-03-28 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45392/#review125734 --- Ship it! Ship It! - Steve Niemitz On March 28, 2016, 6:12

Re: Review Request 54754: Fixed starting cron jobs when using default_docker_parameters

2017-01-27 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54754/#review163337 --- Wow I forgot I even submitted this! - Steve Niemitz On Dec. 15