Re: Review Request 50685: Support TBinaryProtocol over HTTP

2016-08-04 Thread Kunal Thakar
685/#comment210905> s/with/without - Kunal Thakar On Aug. 3, 2016, 10:29 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 45042: Add ACL support for announcer

2016-03-30 Thread Kunal Thakar
ache/aurora/executor/bin/test_thermos_executor_entry_point.py e9f7851292aef3a36da5da9b0fc333a7e7750cf3 src/test/python/apache/aurora/executor/common/test_announcer.py 142b58d5e577c9f4b8e2ae8473cffdea94eba21f Diff: https://reviews.apache.org/r/45042/diff/ Testing --- /vagrant/src/test/sh/org/apache/aurora/e2e/test_announcer_auth_end_to_end.sh /vagrant/src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kunal Thakar

Re: Review Request 45042: Add ACL support for announcer

2016-03-30 Thread Kunal Thakar
als > > here. Since our hand is forced to store plaintext for the auth section, we > > might as well make this part plaintext too. That leaves us with the burden > > of handling the digest step, but that shouldn't be too bad. > > Kunal Thakar wrote: > I

Re: Review Request 45042: Add ACL support for announcer

2016-03-30 Thread Kunal Thakar
March 30, 2016, 2:20 a.m., Bill Farner wrote: > > src/test/sh/org/apache/aurora/e2e/validate_serverset.py, line 50 > > <https://reviews.apache.org/r/45042/diff/7/?file=1318577#file1318577line50> > > > > Is this needed? If so, please include a comment explaining w

Re: Review Request 45042: Add ACL support for announcer

2016-03-29 Thread Kunal Thakar
/validate_serverset.py fca1137bd2e7b1306a03dc2a54d2ef15b59af6a8 Diff: https://reviews.apache.org/r/45042/diff/ Testing --- /vagrant/src/test/sh/org/apache/aurora/e2e/test_announcer_auth_end_to_end.sh /vagrant/src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kunal Thakar

Re: Review Request 45042: Add ACL support for announcer

2016-03-29 Thread Kunal Thakar
en on the configuration provider to keep it simple. - Kunal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/#review125773 ------

Re: Review Request 45042: Add ACL support for announcer

2016-03-28 Thread Kunal Thakar
rset.py fca1137bd2e7b1306a03dc2a54d2ef15b59af6a8 Diff: https://reviews.apache.org/r/45042/diff/ Testing (updated) --- /vagrant/src/test/sh/org/apache/aurora/e2e/test_announcer_auth_end_to_end.sh /vagrant/src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kunal Thakar

Re: Review Request 45042: Add ACL support for announcer

2016-03-28 Thread Kunal Thakar
: > > } > > } > > ] > > ``` > > > > The > > [scheme](http://zookeeper.apache.org/doc/r3.1.2/zookeeperProgrammers.html#sc_BuiltinACLSchemes) > > defines the encoding of the `credential` field. Note that these field

Re: Review Request 45042: Add ACL support for announcer

2016-03-28 Thread Kunal Thakar
t_announcer_auth_end_to_end.sh PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b469f9bbbdfbf98df947832411bd0cdce97affdc src/test/sh/org/apache/aurora/e2e/validate_serverset.py fca1137bd2e7b1306a03dc2a54d2ef15b59af6a8 Diff: https://reviews.apache.org/r/45042/diff/ Testing --- Thanks, Kunal Thakar

Re: Review Request 45042: Add ACL support for announcer

2016-03-22 Thread Kunal Thakar
on/test_announcer.py 142b58d5e577c9f4b8e2ae8473cffdea94eba21f Diff: https://reviews.apache.org/r/45042/diff/ Testing --- Thanks, Kunal Thakar

Re: Review Request 45042: Add ACL support for announcer

2016-03-22 Thread Kunal Thakar
ain.py 6634506108c346f8c23b2da7cc8d20d09d07d590 src/main/python/apache/aurora/executor/common/announcer.py 79a9cfb6ac3a8444f09fb3658e6e859e06941ba4 src/test/python/apache/aurora/executor/common/test_announcer.py 142b58d5e577c9f4b8e2ae8473cffdea94eba21f Diff: https://reviews.apache.org/r/45042/diff/ Testing --- Thanks, Kunal Thakar

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar
/python/apache/aurora/executor/common/test_announcer.py f4032c7302f4733ab5670322b1905102c200f1c9 Diff: https://reviews.apache.org/r/44532/diff/ Testing --- Tested on vagrant with a wrapper for the executor Thanks, Kunal Thakar

Review Request 45042: Add ACL support for announcer

2016-03-19 Thread Kunal Thakar
rora/executor/bin/thermos_executor_main.py f82858c528808d2a9e77bb56f16e897cfb5bbe73 src/main/python/apache/aurora/executor/common/announcer.py 34e36e0a59093468a8934f58bacb68512949347c src/test/python/apache/aurora/executor/common/test_announcer.py f4032c7302f4733ab5670322b1905102c200f1c9 Diff: https://reviews.apache.org/r/45042/diff/ Testing --- Thanks, Kunal Thakar

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar
f4032c7302f4733ab5670322b1905102c200f1c9 Diff: https://reviews.apache.org/r/44532/diff/ Testing --- Tested on vagrant with a wrapper for the executor Thanks, Kunal Thakar

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar
vagrant with a wrapper for the executor Thanks, Kunal Thakar

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar
/test_announcer.py f4032c7302f4733ab5670322b1905102c200f1c9 Diff: https://reviews.apache.org/r/44532/diff/ Testing --- Tested on vagrant with a wrapper for the executor Thanks, Kunal Thakar

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar
://reviews.apache.org/r/44532/diff/ Testing --- Tested on vagrant with a wrapper for the executor Thanks, Kunal Thakar

Re: Review Request 45042: Add ACL support for announcer

2016-03-18 Thread Kunal Thakar
ecutor/common/test_announcer.py 142b58d5e577c9f4b8e2ae8473cffdea94eba21f Diff: https://reviews.apache.org/r/45042/diff/ Testing --- Thanks, Kunal Thakar

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-15 Thread Kunal Thakar
/diff/ Testing (updated) --- Tested on vagrant with a wrapper for the executor Thanks, Kunal Thakar

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-15 Thread Kunal Thakar
--- Thanks, Kunal Thakar

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-10 Thread Kunal Thakar
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review123011 --- On March 8, 2016, 10:33 p.m., Kunal Thakar wrote: > > -

Review Request 44532: Allow overriding hostname before announcing

2016-03-08 Thread Kunal Thakar
/r/44532/diff/ Testing --- Thanks, Kunal Thakar

Re: Review Request 42656: Don't destroy session between requests with TRequestsTransport

2016-03-07 Thread Kunal Thakar
https://reviews.apache.org/r/42656/diff/ Testing --- ./pants test.pytest src/test/python:: Thanks, Kunal Thakar

Re: Review Request 42656: Don't destroy session between requests with TRequestsTransport

2016-02-17 Thread Kunal Thakar
909021ac203185862267d4359d332fc169a06b7e src/test/python/apache/aurora/common/test_transport.py 1f589a9ae08e1f13be34ad6002ceb11a43fdeb5f Diff: https://reviews.apache.org/r/42656/diff/ Testing --- ./pants test.pytest src/test/python:: Thanks, Kunal Thakar

Re: Review Request 43112: Make --announcer-enable optional no-op instead of removing it completely.

2016-02-02 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43112/#review117504 --- Ship it! Ship It! - Kunal Thakar On Feb. 2, 2016, 10:13 p.m

Review Request 42975: Change the way arguments are passed to scheduler in debian

2016-01-29 Thread Kunal Thakar
on, modify /etc/default/aurora-scheduler on the test vagrant box: THERMOS_EXECUTOR_FLAGS="--enable-announcer --announcer-ensemble localhost:2181" After replacing that line, restart the scheduler. sudo systemctl restart aurora-scheduler (it should fail without this change) Thanks, Kunal Thakar

Review Request 42656: Don't destroy session between requests with TRequestsTransport

2016-01-22 Thread Kunal Thakar
1f589a9ae08e1f13be34ad6002ceb11a43fdeb5f Diff: https://reviews.apache.org/r/42656/diff/ Testing --- ./pants test.pytest src/test/python:: Thanks, Kunal Thakar

Re: Review Request 41809: Allow custom announce path

2016-01-06 Thread Kunal Thakar
. Thanks, Kunal Thakar

Re: Review Request 41809: Allow custom announce path

2016-01-06 Thread Kunal Thakar
/build.sh Manually tested the changes in vagrant. Thanks, Kunal Thakar

Re: Review Request 41809: Allow custom announce path

2016-01-05 Thread Kunal Thakar
dda76f018f472d7d8228459eb89f4c5daf9df26d src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955 Diff: https://reviews.apache.org/r/41809/diff/ Testing --- Ran tests ./build-support/jenkins/build.sh Manually tested the changes in vagrant. Thanks, Kunal

Re: Review Request 41809: Allow custom announce path

2016-01-05 Thread Kunal Thakar
eviews.apache.org/r/41809/#review112675 ------- On Jan. 5, 2016, 7:51 p.m., Kunal Thakar wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 41809: Allow custom announce path

2016-01-05 Thread Kunal Thakar
tests ./build-support/jenkins/build.sh Manually tested the changes in vagrant. Thanks, Kunal Thakar

Re: Review Request 41809: Allow custom announce path

2016-01-04 Thread Kunal Thakar
/common/test_announcer.py 46ad784987b626e10e235831707540b807158955 Diff: https://reviews.apache.org/r/41809/diff/ Testing (updated) --- Ran tests ./build-support/jenkins/build.sh Manually tested the changes in vagrant. Thanks, Kunal Thakar

Re: Review Request 41809: Allow custom announce path

2016-01-04 Thread Kunal Thakar
/aurora:all Manually tested the changes in vagrant. Thanks, Kunal Thakar

Review Request 41809: Allow custom announce path

2015-12-30 Thread Kunal Thakar
./pants test src/test/python/apache/aurora:all Manually tested the changes in vagrant. Thanks, Kunal Thakar