Re: Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

[Zameer Manji]

> On Jan. 29, 2016, 3:32 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 87
> > 
> >
> > I suggest you raise the default to a very conservative level (like 1 
> > minute) until we better understand how the newly-introduced locking affects 
> > the app.  A high timeout means potentially waiting longer, but avoids 
> > issues where parts of the app because we don't handle a lock timeout.

Done.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42985/#review117049
---


On Feb. 1, 2016, 2:44 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42985/
> ---
> 
> (Updated Feb. 1, 2016, 2:44 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1596
> https://issues.apache.org/jira/browse/AURORA-1596
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a flag to configure H2 LOCK_TIMEOUT.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> a0344f7f6bf2b468820a2279a36bd6c945d760c0 
> 
> Diff: https://reviews.apache.org/r/42985/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42985/
---

(Updated Feb. 1, 2016, 2:44 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Bill's feedback.


Bugs: AURORA-1596
https://issues.apache.org/jira/browse/AURORA-1596


Repository: aurora


Description
---

Add a flag to configure H2 LOCK_TIMEOUT.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
a0344f7f6bf2b468820a2279a36bd6c945d760c0 

Diff: https://reviews.apache.org/r/42985/diff/


Testing
---


Thanks,

Zameer Manji

Re: Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42985/#review117227
---


Ship it!




Ship It!

- Joshua Cohen


On Jan. 29, 2016, 11:23 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42985/
> ---
> 
> (Updated Jan. 29, 2016, 11:23 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1596
> https://issues.apache.org/jira/browse/AURORA-1596
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a flag to configure H2 LOCK_TIMEOUT.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 8b8c54a116726aa7d3400a54df6439fd368258e7 
> 
> Diff: https://reviews.apache.org/r/42985/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42985/#review117065
---



Master (0eb753d) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 29, 2016, 11:23 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42985/
> ---
> 
> (Updated Jan. 29, 2016, 11:23 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1596
> https://issues.apache.org/jira/browse/AURORA-1596
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a flag to configure H2 LOCK_TIMEOUT.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 8b8c54a116726aa7d3400a54df6439fd368258e7 
> 
> Diff: https://reviews.apache.org/r/42985/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42985/#review117045
---


Ship it!




Ship It!

- John Sirois


On Jan. 29, 2016, 4:23 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42985/
> ---
> 
> (Updated Jan. 29, 2016, 4:23 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1596
> https://issues.apache.org/jira/browse/AURORA-1596
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a flag to configure H2 LOCK_TIMEOUT.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 8b8c54a116726aa7d3400a54df6439fd368258e7 
> 
> Diff: https://reviews.apache.org/r/42985/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 42985: Add a flag to configure H2 LOCK_TIMEOUT.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42985/#review117049
---


Fix it, then Ship it!





src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java (line 87)


I suggest you raise the default to a very conservative level (like 1 
minute) until we better understand how the newly-introduced locking affects the 
app.  A high timeout means potentially waiting longer, but avoids issues where 
parts of the app because we don't handle a lock timeout.


- Bill Farner


On Jan. 29, 2016, 3:23 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42985/
> ---
> 
> (Updated Jan. 29, 2016, 3:23 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1596
> https://issues.apache.org/jira/browse/AURORA-1596
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a flag to configure H2 LOCK_TIMEOUT.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 8b8c54a116726aa7d3400a54df6439fd368258e7 
> 
> Diff: https://reviews.apache.org/r/42985/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>