Re: Review Request 47373: Batching explicit task reconciliation calls

2016-05-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47373/#review133387 --- Master (485da81) is red with this patch. ./build-support/jenkins

Re: Review Request 47373: Batching explicit task reconciliation calls

2016-05-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47373/ --- (Updated May 16, 2016, 5:13 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 47373: Batching explicit task reconciliation calls

2016-05-16 Thread Maxim Khutornenko
> On May 14, 2016, 1:54 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java, > > line 138 > > > > > > Is that really copy necessary? Not really, the only reason

Re: Review Request 47373: Batching explicit task reconciliation calls

2016-05-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47373/#review133359 --- Ship it! Ship It! - Joshua Cohen On May 13, 2016, 11:23 p.m.

Re: Review Request 47373: Batching explicit task reconciliation calls

2016-05-14 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47373/#review133271 --- Ship it! Looks good to me! src/main/java/org/apache/aurora/sc

Re: Review Request 47373: Batching explicit task reconciliation calls

2016-05-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47373/#review133230 --- Ship it! Master (485da81) is green with this patch. ./build-s

Review Request 47373: Batching explicit task reconciliation calls

2016-05-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47373/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Repository: aurora D