Re: Review Request 52884: Document how to create a custom CLI build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review154890 --- The patch looks good and got signed off by a sufficient number of committers. I will therefore proceeed and merge it. - Stephan Erb On Oct. 14, 2016, 5:03 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52884/ > --- > > (Updated Oct. 14, 2016, 5:03 p.m.) > > > Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Document how to create a custom pex that you can use to put > deployment-specific customizations. > > I think the dependency section needs some work, but I'm not an expert on > pants and how it resolves dependencies. Currently we just have the forked > sources in the same repo, so we can point directly to the OSS build target. I > don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left > to the user to make that dependency available in their repo. Can anyone help > fill out that section? > > > Diffs > - > > docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14 > > Diff: https://reviews.apache.org/r/52884/diff/ > > > Testing > --- > > > Thanks, > > David McLaughlin > >
Re: Review Request 52884: Document how to create a custom CLI build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review152861 --- Ship it! Master (ac8b802) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 14, 2016, 3:03 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52884/ > --- > > (Updated Oct. 14, 2016, 3:03 p.m.) > > > Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Document how to create a custom pex that you can use to put > deployment-specific customizations. > > I think the dependency section needs some work, but I'm not an expert on > pants and how it resolves dependencies. Currently we just have the forked > sources in the same repo, so we can point directly to the OSS build target. I > don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left > to the user to make that dependency available in their repo. Can anyone help > fill out that section? > > > Diffs > - > > docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14 > > Diff: https://reviews.apache.org/r/52884/diff/ > > > Testing > --- > > > Thanks, > > David McLaughlin > >
Re: Review Request 52884: Document how to create a custom CLI build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review152857 --- @ReviewBot retry - Stephan Erb On Oct. 14, 2016, 5:03 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52884/ > --- > > (Updated Oct. 14, 2016, 5:03 p.m.) > > > Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Document how to create a custom pex that you can use to put > deployment-specific customizations. > > I think the dependency section needs some work, but I'm not an expert on > pants and how it resolves dependencies. Currently we just have the forked > sources in the same repo, so we can point directly to the OSS build target. I > don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left > to the user to make that dependency available in their repo. Can anyone help > fill out that section? > > > Diffs > - > > docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14 > > Diff: https://reviews.apache.org/r/52884/diff/ > > > Testing > --- > > > Thanks, > > David McLaughlin > >
Re: Review Request 52884: Document how to create a custom CLI build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review152858 --- Ship it! Ship It! - Stephan Erb On Oct. 14, 2016, 5:03 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52884/ > --- > > (Updated Oct. 14, 2016, 5:03 p.m.) > > > Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Document how to create a custom pex that you can use to put > deployment-specific customizations. > > I think the dependency section needs some work, but I'm not an expert on > pants and how it resolves dependencies. Currently we just have the forked > sources in the same repo, so we can point directly to the OSS build target. I > don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left > to the user to make that dependency available in their repo. Can anyone help > fill out that section? > > > Diffs > - > > docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14 > > Diff: https://reviews.apache.org/r/52884/diff/ > > > Testing > --- > > > Thanks, > > David McLaughlin > >
Re: Review Request 52884: Document how to create a custom CLI build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review152706 --- Ship it! We do build sdists but we don't upload them to PyPI. We did once in the past and we could make that apart of our release cycle (like creating binary packages). - Zameer Manji On Oct. 14, 2016, 8:03 a.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52884/ > --- > > (Updated Oct. 14, 2016, 8:03 a.m.) > > > Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Document how to create a custom pex that you can use to put > deployment-specific customizations. > > I think the dependency section needs some work, but I'm not an expert on > pants and how it resolves dependencies. Currently we just have the forked > sources in the same repo, so we can point directly to the OSS build target. I > don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left > to the user to make that dependency available in their repo. Can anyone help > fill out that section? > > > Diffs > - > > docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14 > > Diff: https://reviews.apache.org/r/52884/diff/ > > > Testing > --- > > > Thanks, > > David McLaughlin > >
Re: Review Request 52884: Document how to create a custom CLI build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review152691 --- Ship it! Ship It! - Joshua Cohen On Oct. 14, 2016, 3:03 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52884/ > --- > > (Updated Oct. 14, 2016, 3:03 p.m.) > > > Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Document how to create a custom pex that you can use to put > deployment-specific customizations. > > I think the dependency section needs some work, but I'm not an expert on > pants and how it resolves dependencies. Currently we just have the forked > sources in the same repo, so we can point directly to the OSS build target. I > don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left > to the user to make that dependency available in their repo. Can anyone help > fill out that section? > > > Diffs > - > > docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14 > > Diff: https://reviews.apache.org/r/52884/diff/ > > > Testing > --- > > > Thanks, > > David McLaughlin > >
Re: Review Request 52884: Document how to create a custom CLI build
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52884/#review152681
---
Master (8256000) is red with this patch.
./build-support/jenkins/build.sh
[1m# Create file stdout for capturing output. We
can't use StringIO mock[0m
[1m# because TestProcess is running fork.[0m
[1mwith open(os.path.join(td, 'sys_stdout'),
'w+') as stdout:[0m
[1m with open(os.path.join(td, 'sys_stderr'),
'w+') as stderr:[0m
[1mwith mutable_sys():[0m
[1m sys.stdout, sys.stderr = stdout,
stderr[0m
[1m[0m
[1m p = TestProcess('process', 'echo hello
world; echo >&2 hello stderr', 0,[0m
[1m taskpath, sandbox,
logger_destination=LoggerDestination.BOTH)[0m
[1m p.start()[0m
[1m rc =
wait_for_rc(taskpath.getpath('process_checkpoint'))[0m
[1m[0m
[1m assert rc == 0[0m
[1m # Check log files were created in std
path with correct content[0m
[1m> assert_log_content(taskpath, 'stdout',
'hello world\n')[0m
src/test/python/apache/thermos/core/test_process.py:487:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
taskpath =
log_name = 'stdout'
expected_content = 'hello world\n'
[1mdef assert_log_content(taskpath, log_name,
expected_content):[0m
[1m log =
taskpath.with_filename(log_name).getpath('process_logdir')[0m
[1m assert os.path.exists(log)[0m
[1m with open(log, 'r') as fp:[0m
[1m> assert fp.read() == expected_content[0m
[1m[31mE assert '' == 'hello world\n'[0m
[1m[31mE + hello world[0m
src/test/python/apache/thermos/core/test_process.py:313:
AssertionError
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 715 passed, 6 skipped, 1 warnings in
219.52 seconds [0m
FAILURE
15:15:51 04:08 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Oct. 14, 2016, 3:03 p.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52884/
> ---
>
> (Updated Oct. 14, 2016, 3:03 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Document how to create a custom pex that you can use to put
> deployment-specific customizations.
>
> I think the dependency section needs some work, but I'm not an expert on
> pants and how it resolves dependencies. Currently we just have the forked
> sources in the same repo, so we can point directly to the OSS build target. I
> don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left
> to the user to make that dependency available in their repo. Can anyone help
> fill out that section?
>
>
> Diffs
> -
>
> docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14
>
> Diff: https://reviews.apache.org/r/52884/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> David McLaughlin
>
>
Review Request 52884: Document how to create a custom CLI build
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/ --- Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji. Repository: aurora Description --- Document how to create a custom pex that you can use to put deployment-specific customizations. I think the dependency section needs some work, but I'm not an expert on pants and how it resolves dependencies. Currently we just have the forked sources in the same repo, so we can point directly to the OSS build target. I don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left to the user to make that dependency available in their repo. Can anyone help fill out that section? Diffs - docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14 Diff: https://reviews.apache.org/r/52884/diff/ Testing --- Thanks, David McLaughlin
