Re: Review Request 33366: Fix the path to download stdout/stderr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 21, 2015, 6:53 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- - incorporate review comments from @zmanji in irc. - fix tests Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Download url for stdout/stderr broken Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs (updated) - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION src/test/python/apache/thermos/observer/http/test_file_browser.py PRE-CREATION Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: Fix the path to download stdout/stderr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review81042 --- Ship it! src/test/python/apache/thermos/observer/http/test_file_browser.py https://reviews.apache.org/r/33366/#comment131262 Please remove `int(x)` and replace it with `x` everywhere in this file. - Zameer Manji On April 21, 2015, 11:53 a.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 21, 2015, 11:53 a.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Download url for stdout/stderr broken Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION src/test/python/apache/thermos/observer/http/test_file_browser.py PRE-CREATION Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: Fix the path to download stdout/stderr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 21, 2015, 7:53 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- handle review comments from zmanji Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Download url for stdout/stderr broken Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs (updated) - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION src/test/python/apache/thermos/observer/http/test_file_browser.py PRE-CREATION Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: Fix the path to download stdout/stderr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review81055 --- Ship it! I'd like to note that our best practice is to use `mock.patch` sparingly, as it tends to suggest poorly-factored code and results in tests that can be difficult to reason about. However, since the observer may be overhauled in the not-too-distant future, a refactoring would not have been wise and i believe this is an appropriate use of patching. - Bill Farner On April 21, 2015, 7:53 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 21, 2015, 7:53 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Download url for stdout/stderr broken Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION src/test/python/apache/thermos/observer/http/test_file_browser.py PRE-CREATION Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: Fix the path to download stdout/stderr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review80823 --- Ship it! Master (b18dc44) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On April 20, 2015, 9 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 20, 2015, 9 p.m.) Review request for Aurora. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Download url for stdout/stderr broken Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION src/test/python/apache/thermos/observer/http/test_file_browser.py PRE-CREATION Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: Fix the path to download stdout/stderr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 20, 2015, 9 p.m.) Review request for Aurora. Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description --- Download url for stdout/stderr broken Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs (updated) - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION src/test/python/apache/thermos/observer/http/test_file_browser.py PRE-CREATION Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: Fix the path to download stdout/stderr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 20, 2015, 8:15 p.m.) Review request for Aurora. Summary (updated) - Fix the path to download stdout/stderr Bugs: AURORA-1135 https://issues.apache.org/jira/browse/AURORA-1135 Repository: aurora Description (updated) --- Download url for stdout/stderr broken Make it relative to sandbox. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1135 Diffs (updated) - src/main/python/apache/thermos/observer/http/file_browser.py 2f48594a87724b84bad7e149eb4d63c71ea954ee src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION src/test/python/apache/thermos/observer/http/test_file_browser.py PRE-CREATION Diff: https://reviews.apache.org/r/33366/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 33366: Fix the path to download stdout/stderr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review80812 --- Master (b18dc44) is red with this patch. ./build-support/jenkins/build.sh SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_quota.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_command_hooks.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_supdate.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_cancel_update.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_config_noun.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_create.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_kill.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_status.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_diff.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_inspect.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_update.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_plugins.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_restart.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_cron.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_client.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/__init__.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_api_from_cli.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/util.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_version.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_open.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_context.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/hooks/test_hooked_api.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_sla.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_api.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_health_check.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_job_monitor.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_updater_util.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_scheduler_mux.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_scheduler_client.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_quota_check.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_instance_watcher.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_updater.py Everything Looks Good! SUCCESS: