Re: Review Request 33456: Adding logging threadpool executor.

2015-05-01 Thread Maxim Khutornenko
> On April 27, 2015, 8 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 > > > > > > Have you considered creating factory methods that apply decorators to > > ExecutorS

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/#review81912 --- Ship it! I'll let you make the call here. I think the decorator me

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-28 Thread Maxim Khutornenko
> On April 27, 2015, 8 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 > > > > > > Have you considered creating factory methods that apply decorators to > > ExecutorS

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-28 Thread Bill Farner
> On April 27, 2015, 8 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 > > > > > > Have you considered creating factory methods that apply decorators to > > ExecutorS

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-28 Thread Bill Farner
> On April 27, 2015, 8 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 > > > > > > Have you considered creating factory methods that apply decorators to > > ExecutorS

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-28 Thread Bill Farner
> On April 27, 2015, 8 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 > > > > > > Have you considered creating factory methods that apply decorators to > > ExecutorS

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-28 Thread Maxim Khutornenko
> On April 27, 2015, 8 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 > > > > > > Have you considered creating factory methods that apply decorators to > > ExecutorS

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/#review81725 --- src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/#review81240 --- Ship it! Master (352e0ef) is green with this patch. ./build-suppo

Review Request 33456: Adding logging threadpool executor.

2015-04-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---