Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127222 --- Ship it! Ship It! - Stephan Erb On April 5, 2016, 11 nachm.,

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127219 --- Ship it! Ship It! - Zameer Manji On April 5, 2016, 2 p.m., B

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127218 --- Ship it! Master (5109788) is green with this patch. ./build-s

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/ --- (Updated April 5, 2016, 2 p.m.) Review request for Aurora, Maxim Khutornenko an

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127213 --- Ship it! Mod dropping /locks endpoint. - Maxim Khutornenko O

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Bill Farner
> On April 5, 2016, 7:06 a.m., Stephan Erb wrote: > > Just checking my understanding here: > > > > * the ticket reads like we first have to deprecate the locks, and then > > remove them. This review request seems to do this in one sitting. This is > > considered ok, because thrift will guarant

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Maxim Khutornenko
> On April 5, 2016, 2:06 p.m., Stephan Erb wrote: > > Just checking my understanding here: > > > > * the ticket reads like we first have to deprecate the locks, and then > > remove them. This review request seems to do this in one sitting. This is > > considered ok, because thrift will guarant

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Bill Farner
> On April 5, 2016, 7:06 a.m., Stephan Erb wrote: > > Just checking my understanding here: > > > > * the ticket reads like we first have to deprecate the locks, and then > > remove them. This review request seems to do this in one sitting. This is > > considered ok, because thrift will guarant

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Maxim Khutornenko
> On April 5, 2016, 2:06 p.m., Stephan Erb wrote: > > Just checking my understanding here: > > > > * the ticket reads like we first have to deprecate the locks, and then > > remove them. This review request seems to do this in one sitting. This is > > considered ok, because thrift will guarant

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127098 --- Just checking my understanding here: * the ticket reads like we f

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127010 --- Ship it! Master (f402899) is green with this patch. ./build-s

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/ --- (Updated April 4, 2016, 7:09 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/ --- (Updated April 4, 2016, 7:04 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127004 --- Ship it! Master (f402899) is green with this patch. ./build-s

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/ --- (Updated April 4, 2016, 6:50 p.m.) Review request for Aurora, Maxim Khutornenko

Review Request 45718: Remove lock-related constructs from the API.

2016-04-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Repository: auro