Re: Review Request 51484: Re-enable python style check in the integration build.

Thanks John. I have fixed my account details on review board. On Mon, Aug 29, 2016 at 10:05 AM, John Sirois wrote: > > > > On Aug. 29, 2016, 10:39 a.m., John Sirois wrote: > > > I'm taking a look presently. The seperate script call-out should no > longer be needed since

Re: Review Request 51484: Re-enable python style check in the integration build.

> On Aug. 29, 2016, 10:39 a.m., John Sirois wrote: > > I'm taking a look presently. The seperate script call-out should no longer > > be needed since `./pants test...` implies `./pants compile...` which is all > > the seperate script does. > > John Sirois wrote: > Aha - yes, the compile

Re: Review Request 51484: Re-enable python style check in the integration build.

> On Aug. 29, 2016, 4:39 p.m., John Sirois wrote: > > I'm taking a look presently. The seperate script call-out should no longer > > be needed since `./pants test...` implies `./pants compile...` which is all > > the seperate script does. > > John Sirois wrote: > Aha - yes, the compile

Re: Review Request 51484: Re-enable python style check in the integration build.

> On Aug. 29, 2016, 10:39 a.m., John Sirois wrote: > > I'm taking a look presently. The seperate script call-out should no longer > > be needed since `./pants test...` implies `./pants compile...` which is all > > the seperate script does. > > John Sirois wrote: > Aha - yes, the compile

Re: Review Request 51484: Re-enable python style check in the integration build.

> On Aug. 29, 2016, 4:39 p.m., John Sirois wrote: > > I'm taking a look presently. The seperate script call-out should no longer > > be needed since `./pants test...` implies `./pants compile...` which is all > > the seperate script does. > > John Sirois wrote: > Aha - yes, the compile

Re: Review Request 51484: Re-enable python style check in the integration build.

> On Aug. 29, 2016, 10:39 a.m., John Sirois wrote: > > I'm taking a look presently. The seperate script call-out should no longer > > be needed since `./pants test...` implies `./pants compile...` which is all > > the seperate script does. > > John Sirois wrote: > Aha - yes, the compile

Re: Review Request 51484: Re-enable python style check in the integration build.

> On Aug. 29, 2016, 10:44 a.m., John Sirois wrote: > > Ship It! Zameer - I'll patch this in directly without your review since its straightforward. - John --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 51484: Re-enable python style check in the integration build.

> On Aug. 29, 2016, 10:39 a.m., John Sirois wrote: > > I'm taking a look presently. The seperate script call-out should no longer > > be needed since `./pants test...` implies `./pants compile...` which is all > > the seperate script does. Aha - yes, the compile dependency was historically

Re: Review Request 51484: Re-enable python style check in the integration build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51484/#review147142 --- Ship it! Ship It! - John Sirois On Aug. 27, 2016, 10:40

Re: Review Request 51484: Re-enable python style check in the integration build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51484/#review147139 --- I'm taking a look presently. The seperate script call-out should

Re: Review Request 51484: Re-enable python style check in the integration build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51484/#review147094 --- Ship it! Master (4a2aff9) is green with this patch.