Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151585 --- Master (640f07b) is green with this patch.

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

> On Oct. 5, 2016, 3:13 p.m., Aurora ReviewBot wrote: > > Master (640f07b) is red with this patch. > > ./build-support/jenkins/build.sh > > > > # Create file stdout for capturing output. > > We can't use StringIO mock > > 

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151582 --- @ReviewBot retry - Zameer Manji On Oct. 5, 2016, 3:01 p.m.,

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

> On Oct. 5, 2016, 3:13 p.m., Aurora ReviewBot wrote: > > Master (640f07b) is red with this patch. > > ./build-support/jenkins/build.sh > > > > # Create file stdout for capturing output. > > We can't use StringIO mock > > 

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151573 --- Master (640f07b) is red with this patch.

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/ --- (Updated Oct. 5, 2016, 10:01 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/ --- (Updated Oct. 5, 2016, 9:49 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151540 --- Kai, I'm getting conflicts when commiting this. Can you first

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151539 --- Ship it! Ship It! - Zameer Manji On Oct. 4, 2016, 11:09

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151464 --- This patch does not apply cleanly against RB#52094 (251ef5a), do

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/ --- (Updated Oct. 5, 2016, 6:09 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

> On Oct. 4, 2016, 7:17 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/api/updater_util.py, line 39 > > > > > > "Watch seconds should not be negative." sure. Will do. - Kai

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151372 --- On further reflection, can you also add a section documenting of

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151373 --- Changes LGTM. Can we add documentation as well? We need to

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

> On Oct. 4, 2016, 6:36 a.m., Kai Huang wrote: > > I noticed that AuroraBot says the test is green but some coverage are > > missing... > > > > When I test the code locally, the code passes pants tests and style check > > in: > > ./build-support/jenkins/build.sh > > > > it also passes

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

> On Oct. 4, 2016, 6:36 a.m., Kai Huang wrote: > > I noticed that AuroraBot says the test is green but some coverage are > > missing... > > > > When I test the code locally, the code passes pants tests and style check > > in: > > ./build-support/jenkins/build.sh > > > > it also passes

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151303 --- I noticed that AuroraBot says the test is green but some coverage

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151282 --- Master (ed72b1b) is green with this patch.

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/ --- (Updated Oct. 4, 2016, 12:42 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151175 --- Ship it! Ship It! - Joshua Cohen On Sept. 30, 2016, 10:53

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151173 --- Ship it! Ship It! - Stephan Erb On Oct. 1, 2016, 12:53