Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-12-03 Thread John Sirois
> On Sept. 26, 2017, 5:53 p.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-12-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/#review192648 --- Master (89338dd) is red with this patch.

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-12-03 Thread Stephan Erb
> On Sept. 27, 2017, 1:53 a.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-12-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/ --- (Updated Dec. 3, 2017, 9:09 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-11-11 Thread Renan DelValle
> On Nov. 9, 2017, 6:04 p.m., Renan DelValle wrote: > > I'm all for the upgrade to Thrift 0.10.0 but we should announce plans to > > upgrade ASAP to the mailing lists because it'll break every go thrift > > client due to https://issues.apache.org/jira/browse/THRIFT-3467 . It says > > it was

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-11-11 Thread Bill Farner
> On Nov. 9, 2017, 6:04 p.m., Renan DelValle wrote: > > I'm all for the upgrade to Thrift 0.10.0 but we should announce plans to > > upgrade ASAP to the mailing lists because it'll break every go thrift > > client due to https://issues.apache.org/jira/browse/THRIFT-3467 . It says > > it was

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-11-09 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/#review190663 --- I'm all for the upgrade to Thrift 0.10.0 but we should announce

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-11-09 Thread Bill Farner
> On Sept. 26, 2017, 4:53 p.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-10-25 Thread Bill Farner
> On Sept. 26, 2017, 4:53 p.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-10-25 Thread Stephan Erb
> On Sept. 27, 2017, 1:53 a.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-10-03 Thread Bill Farner
> On Sept. 26, 2017, 4:53 p.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-10-03 Thread Stephan Erb
> On Sept. 27, 2017, 1:53 a.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-09-27 Thread Bill Farner
> On Sept. 26, 2017, 4:53 p.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-09-27 Thread Stephan Erb
> On Sept. 27, 2017, 1:53 a.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) Bison on MacOs is 10 years old. I assumed they have a good

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-09-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/#review186342 --- ``` /bin/sh: cmake: command not found ``` But now i need to

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-09-26 Thread Bill Farner
> On Sept. 26, 2017, 4:53 p.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. (this = the switch to cmake) - Bill --- This is an

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-09-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/#review186324 --- Master (0606369) is red with this patch.

Review Request 62590: WIP: Update to Thrift 0.10.0

2017-09-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/ --- Review request for Aurora and Bill Farner. Repository: aurora Description