Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review189674 --- Ship it! Master (87eb891) is green with this patch.

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-30 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/ --- (Updated Oct. 30, 2017, 10:50 p.m.) Review request for Aurora, David

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review189648 --- Ship it! LGTM, with the switch to `CacheBuilder` in

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-30 Thread Bill Farner
> On Oct. 27, 2017, 3:03 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java > > Lines 42-43 (patched) > > > > > > How about a `CacheBuilderSpec` to bundle these? > >

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review189642 --- Ship it! Master (448e6d4) is green with this patch.

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-30 Thread Jordan Ly
> On Oct. 27, 2017, 10:03 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 321 (patched) > > > > > > `expireAfterWrite` doesn't result in LRU. I think you

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-30 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/ --- (Updated Oct. 30, 2017, 6:14 p.m.) Review request for Aurora, David

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review189488 ---

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review188890 --- Ship it! Master (9825e05) is green with this patch.

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review19 --- Master (9825e05) is red with this patch.

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review17 --- Master (9825e05) is red with this patch.

Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

2017-10-20 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/ --- Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, Stephan