Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

2017-10-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63418/#review189686 --- Ship it! Master (87eb891) is green with this patch.

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

2017-10-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63418/#review189675 --- Master (87eb891) is red with this patch.

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

2017-10-30 Thread Stephan Erb
> On Oct. 30, 2017, 7:09 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/ServiceInstance.java > > Lines 45 (patched) > > > > > > Should we just hardcode ALIVE here? Aurora is not

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

2017-10-30 Thread Bill Farner
> On Oct. 30, 2017, 11:09 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/ServiceInstance.java > > Lines 45 (patched) > > > > > > Should we just hardcode ALIVE here? Aurora is not

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

2017-10-30 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63418/#review189627 --- Ship it! Ship It! - Jordan Ly On Oct. 30, 2017, 4:36 p.m.,

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

2017-10-30 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63418/#review189621 --- Ship it! LGTM. One minor thing below that confused me when

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

2017-10-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63418/#review189610 ---

Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

2017-10-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63418/ --- Review request for Aurora, Jordan Ly and Stephan Erb. Repository: aurora