> On Nov. 21, 2017, 9:57 a.m., Stephan Erb wrote:
> > I am not completely through but have a first set of comments.
> >
> > While reviewing this PR I got confused for second in `PruningModule.java`:
> > Please notice the difference between `HistoryPrunnerSettings` vs
> >
> On Nov. 21, 2017, 10:53 a.m., David McLaughlin wrote:
> > Are we sure this was purely a database optimization? This looks like it
> > will now write the entire JobUpdateDetails to the replicated log for every
> > instance event change? In large clusters this could impact write log write
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63884/#review191621
---
Are we sure this was purely a database optimization? This looks
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63884/#review191592
---
I am not completely through but have a first set of comments.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63884/#review191580
---
Ping
- Bill Farner
On Nov. 16, 2017, 10:20 a.m., Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63884/#review191237
---
Ship it!
Master (46b1112) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63884/#review191206
---
Annotated the diff with some reviewer notes.
