Re: Review Request 63973: Enable custom offer scoring modules for task assignment and injecting of custom OfferManagers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191872 --- Master (0f3dc93) is red with this patch.

Re: Review Request 63973: Enable custom offer scoring modules for task assignment and injecting of custom OfferManagers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/ --- (Updated Nov. 27, 2017, 6:44 a.m.) Review request for Aurora, David

Re: Review Request 63973: Enable custom offer scoring modules for task assignment and injecting of custom OfferManagers

> On Nov. 21, 2017, 1:27 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImpl.java > > Lines 140 (patched) > > > > > > Consider moving this up to :122 and replacing >

Re: Review Request 63973: Enable custom offer scoring modules for task assignment and injecting of custom OfferManagers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191709 --- Master (0f3dc93) is red with this patch.

Re: Review Request 63973: Enable custom offer scoring modules for task assignment and injecting of custom OfferManagers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/ --- (Updated Nov. 22, 2017, 8:38 a.m.) Review request for Aurora, David

Re: Review Request 63973: Enable custom offer scoring modules for task assignment and injecting of custom OfferManagers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191644 --- This looks great to me overall. The issue of custom modules is

Re: Review Request 63973: Enable custom offer scoring modules for task assignment and injecting of custom OfferManagers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191561 --- docs/reference/scheduler-configuration.md Line 223 (original),

Review Request 63973: Enable custom offer scoring modules for task assignment and injecting of custom OfferManagers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/ --- Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, Stephan