Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-06-14 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review204770 --- As you have agreed with this patch in general, I will merge it

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-06-14 Thread Stephan Erb
> On March 21, 2018, 6:47 p.m., Santhosh Kumar Shanmugham wrote: > > Ship It! > > Santhosh Kumar Shanmugham wrote: > I am a little confused about the performance testing results that are > posted here, since the pervious results indicated gains from 2secs to > 0.2secs, while the current

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-21 Thread Santhosh Kumar Shanmugham
> On March 21, 2018, 10:47 a.m., Santhosh Kumar Shanmugham wrote: > > Ship It! I am a little confused about the performance testing results that are posted here, since the pervious results indicated gains from 2secs to 0.2secs, while the current one is much lesser. Can you add a little bit of

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-21 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199681 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On March 20,

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-21 Thread Reza Motamedi
> On March 21, 2018, 5:36 p.m., Reza Motamedi wrote: > > Ship It! Can you explain a bit more about the exeperiement settings? - Reza --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-21 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199678 --- Ship it! Ship It! - Reza Motamedi On March 20, 2018, 10:41

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199612 --- Ship it! Master (b3fa9fe) is green with this patch.

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-20 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/ --- (Updated March 20, 2018, 11:41 p.m.) Review request for Aurora, Jordan Ly,

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-20 Thread Stephan Erb
> On March 20, 2018, 9:20 p.m., Reza Motamedi wrote: > > src/main/python/apache/aurora/executor/common/executor_detector.py > > Lines 28-85 (original), 26-38 (patched) > > > > > > We are using the functionalities

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-20 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199564 ---

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199501 --- Ship it! Master (b3fa9fe) is green with this patch.

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-19 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199490 --- @ReviewBot retry - Stephan Erb On March 19, 2018, 5:24 p.m.,

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199442 --- Master (aaadad7) is red with this patch.

Review Request 66139: Speedup regular Thermos observer checkpoint refresh

2018-03-19 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/ --- Review request for Aurora, Jordan Ly and Renan DelValle. Repository: aurora