Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-24 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/#review203817 --- Can you include an end-to-end test?

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-24 Thread Renan DelValle
> On May 3, 2018, 2:41 p.m., Renan DelValle wrote: > > Ship It! Actually, Steve, if you could add some docs here https://github.com/apache/aurora/blob/master/docs/reference/configuration.md I can get Santhosh to review and then hopefully we can get this shipped quick! - Renan

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-03 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/#review202384 --- Ship it! Ship It! - Renan DelValle On May 2, 2018, 6:06

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/#review202372 --- Ship it! Master (a3d596e) is green with this patch.

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-03 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/#review202370 --- @ReviewBot retry - Renan DelValle On May 2, 2018, 6:06 p.m.,

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/#review202339 --- Master (a3d596e) is red with this patch.

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-02 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/#review202336 --- @ReviewBot retry - Renan DelValle On May 2, 2018, 6:06 p.m.,

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/#review202335 --- Master (a3d596e) is red with this patch.

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-02 Thread Steve Salevan
> On April 17, 2018, 10:11 p.m., Renan DelValle wrote: > > Overall looks great! Few fixes here and there and we should be able to land > > this in master quickly. > > > > It would be nice if a check were added for rejecting requests from the > > scheduler side that were misconfigured. > > >

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-02 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/ --- (Updated May 3, 2018, 1:06 a.m.) Review request for Aurora, Renan DelValle and

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-04-17 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/#review201350 --- Overall looks great! Few fixes here and there and we should be

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-04-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/#review200873 --- Ship it! Master (2d6108b) is green with this patch.

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-04-10 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/ --- (Updated April 11, 2018, 2:17 a.m.) Review request for Aurora, Renan DelValle

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-04-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/#review200869 --- Master (2d6108b) is red with this patch.

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-04-10 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/ --- (Updated April 11, 2018, 1:45 a.m.) Review request for Aurora, Renan DelValle

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-04-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/#review200861 --- Master (2d6108b) is red with this patch.

Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-04-10 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/ --- Review request for Aurora. Repository: aurora Description --- Hey