Re: Review Request 20407: AURORA-323:Add ability to merge in github pull requests similar to rbt

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20407/ --- (Updated April 17, 2014, 4 a.m.) Review request for Aurora, Kevin Sweeney and B

Re: Review Request 20398: Scheduler SLA metrics.

> On April 16, 2014, 11:57 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 73 > > > > > > I would find median really useful too. By median you mean JOB_UPTIME_50?

Re: Review Request 19833: Migrated Job page to angular JS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19833/#review40608 --- src/main/resources/org/apache/aurora/scheduler/http/ui/job.html

Re: Review Request 20398: Scheduler SLA metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/#review40606 --- src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java

Re: Review Request 20344: AURORA-267: Add container to popover to avoid clipping issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20344/ --- (Updated April 16, 2014, 9:40 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 20394: Add return code to task/process pages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/ --- (Updated April 16, 2014, 9:38 p.m.) Review request for Aurora and Brian Wickman

Re: Review Request 20425: Shutdown cron asynchronously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20425/#review40602 --- Ship it! src/main/java/org/apache/aurora/scheduler/state/CronJobMa

Re: Review Request 20425: Shutdown cron asynchronously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20425/#review40599 --- Ship it! Ship It! - Maxim Khutornenko On April 16, 2014, 7:52 p.

Re: Review Request 20425: Shutdown cron asynchronously

> On April 16, 2014, 12:56 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java, line > > 177 > > > > > > Would it rather make sense to use a timed wait instead? > >

Re: Review Request 20425: Shutdown cron asynchronously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20425/#review40597 --- src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java

Review Request 20425: Shutdown cron asynchronously

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20425/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-325

Re: Review Request 19833: Migrated Job page to angular JS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19833/ --- (Updated April 16, 2014, 8:37 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 19833: Migrated Job page to angular JS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19833/ --- (Updated April 16, 2014, 8:37 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 19833: Migrated Job page to angular JS

> On April 16, 2014, 12:18 a.m., David McLaughlin wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/job.html, line 30 > > > > > > You don't need noMarginLeft here. The left padding is only applied to >

Re: Review Request 19833: Migrated Job page to angular JS

> On April 6, 2014, 12:24 a.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/job.html, line 62 > > > > > > Can you make this an anchor instead of span? > > > > Also, the issue i

Re: Review Request 19833: Migrated Job page to angular JS

> On April 6, 2014, 12:24 a.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/schedulingDetail.html, > > line 9 > > > > > > remove space before the colon, here and below Done. > On Apr

Re: Review Request 19833: Migrated Job page to angular JS

> On April 15, 2014, 8:15 p.m., Kevin Sweeney wrote: > > A few general Javascript comments: there seems to have been an explosion of > > global state and some controllers are getting pretty big. Consider using > > angular's dependency injection system to keep dependencies explicit and > > mana