Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/ --- Review request for Aurora, David Robinson and Maxim Khutornenko. Bugs:

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19788/ --- (Updated April 21, 2014, 10:57 a.m.) Review request for Aurora, Joe Smith and

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review40883 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review40885 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/ --- (Updated April 21, 2014, 12:36 p.m.) Review request for Aurora, David Robinson

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Maxim Khutornenko
On April 21, 2014, 4:35 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 337 https://reviews.apache.org/r/20521/diff/1/?file=563067#file563067line337 This has nothing to do with hooks: this is how error codes get returned when a verb

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/ --- (Updated April 21, 2014, 12:53 p.m.) Review request for Aurora, David Robinson

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Maxim Khutornenko
On April 21, 2014, 4:53 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 337 https://reviews.apache.org/r/20521/diff/1/?file=563067#file563067line337 The pre-execution plugin takes the same command-context as the actual verb implementation.

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Maxim Khutornenko
On April 21, 2014, 4:53 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 337 https://reviews.apache.org/r/20521/diff/1/?file=563067#file563067line337 The pre-execution plugin takes the same command-context as the actual verb implementation.

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Maxim Khutornenko
On April 21, 2014, 5:45 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 337 https://reviews.apache.org/r/20521/diff/1/?file=563067#file563067line337 The reason for this is because these errors are not intended to be handled. They're fatal,

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/ --- (Updated April 21, 2014, 2:16 p.m.) Review request for Aurora, David Robinson

Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.

2014-04-21 Thread Bill Farner
On April 18, 2014, 8:46 p.m., Maxim Khutornenko wrote: docs/tutorial.md, line 148 https://reviews.apache.org/r/20238/diff/1/?file=554811#file554811line148 Should we rather keep the name here to avoid connecting to a wrong VM in case users have more than one vagrant setup? These

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

2014-04-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/#review40922 --- Kevin, have you tried to submit this since it was last updated? -

Re: Review Request 20344: AURORA-267: Add container to popover to avoid clipping issue

2014-04-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20344/#review40927 --- Ship it! Ship It! - Bill Farner On April 16, 2014, 9:40 p.m.,

Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.

2014-04-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/ --- (Updated April 21, 2014, 7:47 p.m.) Review request for Aurora, Jake Farrell

Re: Review Request 20344: AURORA-267: Add container to popover to avoid clipping issue

2014-04-21 Thread Bill Farner
On April 21, 2014, 7:45 p.m., Bill Farner wrote: Ship It! This is now on master as 48a52ba. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20344/#review40927

Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.

2014-04-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/#review40931 --- Ship it! Ship It! - Kevin Sweeney On April 21, 2014, 12:47

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-21 Thread Maxim Khutornenko
On April 9, 2014, 5:35 p.m., Suman Karumuri wrote: Thanks for the diff Dan. As part of the new UI roll out https://reviews.apache.org/r/19833/, I have removed this file from the server and moved this logic into the client side. I can add these changes as part of that diff or you can

Re: Review Request 20512: Role and Job pages using new Angular UI.

2014-04-21 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20512/ --- (Updated April 21, 2014, 9:39 p.m.) Review request for Aurora and Suman

Re: Review Request 20512: Role and Job pages using new Angular UI.

2014-04-21 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20512/ --- (Updated April 21, 2014, 9:40 p.m.) Review request for Aurora and Suman

Re: Review Request 20512: Role and Job pages using new Angular UI.

2014-04-21 Thread Suman Karumuri
On April 21, 2014, 8:14 p.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 416 https://reviews.apache.org/r/20512/diff/1/?file=562936#file562936line416 Looks like this is set as of the last event, which should be the

Re: Review Request 20512: Role and Job pages using new Angular UI.

2014-04-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20512/#review40965 --- Ship it! lgtm as far as RB:20058 merge goes. - Maxim Khutornenko

Re: Review Request 20285: Improve documentation and testing for host maintenance API

2014-04-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20285/#review40964 --- Ship it! src/main/python/apache/aurora/admin/host_maintenance.py

Re: Review Request 20285: Improve documentation and testing for host maintenance API

2014-04-21 Thread Bill Farner
On April 21, 2014, 9:58 p.m., Bill Farner wrote: src/main/python/apache/aurora/admin/host_maintenance.py, line 93 https://reviews.apache.org/r/20285/diff/1/?file=85#file85line93 Source for the current time Doh, i asked RB to delete this one. - Bill

Re: Review Request 19767: CronScheduler based on Quartz

2014-04-21 Thread Kevin Sweeney
On April 5, 2014, 4:20 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/cron/CronJobManager.java, line 54 https://reviews.apache.org/r/19767/diff/6/?file=549800#file549800line54 s/persisted // (not really relevant) fixed On April 5, 2014, 4:20

Re: Review Request 19767: CronScheduler based on Quartz

2014-04-21 Thread Kevin Sweeney
On April 4, 2014, 6:42 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java, line 54 https://reviews.apache.org/r/19767/diff/6/?file=549802#file549802line54 This is still here contrary to your reply... fixed. - Kevin

Re: Review Request 19767: CronScheduler based on Quartz

2014-04-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19767/ --- (Updated April 21, 2014, 5:38 p.m.) Review request for Aurora, Maxim

Re: Review Request 19767: CronScheduler based on Quartz

2014-04-21 Thread Maxim Khutornenko
On April 5, 2014, 1:42 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java, line 54 https://reviews.apache.org/r/19767/diff/6/?file=549802#file549802line54 This is still here contrary to your reply... Kevin Sweeney wrote: fixed.

Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.

2014-04-21 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/#review40990 --- Ship it! Ship It! - Jake Farrell On April 21, 2014, 7:47 p.m.,