Review Request 25255: Implement server-driven update commands.

2014-09-02 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25255/ --- Review request for Aurora. Repository: aurora Description --- This

Re: Review Request 24915: Adding initial GC task delay on scheduler restart.

2014-09-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24915/#review52037 --- I'm concerned that the problem we're solving is underspecified. An

Re: Review Request 25255: Implement server-driven update commands.

2014-09-02 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25255/#review52043 --- Is the command name supdate up for debate? I'm not in love with it

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/#review52049 --- the test coverage is a great improvement. thanks joe! what's the

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-02 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52065 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 29, 2014, 7:17

Re: Review Request 24752: combine finalization_wait when combining tasks

2014-09-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24752/#review52088 --- Ping, Brian? - Bill Farner On Aug. 28, 2014, 3:27 p.m., Matthew

Re: Review Request 25158: Aurora Update UI

2014-09-02 Thread Bill Farner
On Aug. 28, 2014, 6:51 p.m., Joshua Cohen wrote: This looks nice! I'm assuming the grid is changes in real time as instances are updated? I think I prefer the big preview (the one with the grid as opposed to the progress bar). What are your thoughts on including the update

Re: Review Request 25257: Add a separate main class that runs the scheduler in local mode.

2014-09-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25257/ --- (Updated Sept. 2, 2014, 11:39 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 25257: Add a separate main class that runs the scheduler in local mode.

2014-09-02 Thread Joshua Cohen
On Sept. 2, 2014, 6:31 p.m., Joshua Cohen wrote: src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java, lines 134-135 https://reviews.apache.org/r/25257/diff/1/?file=674033#file674033line134 Any way to avoid magic numbers here (and would it be worthwhile)? As a

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/ --- (Updated Sept. 2, 2014, 5:45 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
On Sept. 2, 2014, 11:08 a.m., Brian Wickman wrote: the test coverage is a great improvement. thanks joe! what's the status of mesos.native + the e2e test? abi incompatible with our vagrant image? Still working on it- Zameer claims success, but I'm waiting to pull down + provision

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
On Sept. 2, 2014, 11:08 a.m., Brian Wickman wrote: src/main/python/apache/aurora/executor/thermos_task_runner.py, lines 45-50 https://reviews.apache.org/r/25208/diff/3/?file=672643#file672643line45 should these be mesos_pb2.TASK_LOST mesos_pb2.TASK_KILLED

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-02 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52121 --- Ship it! src/test/sh/org/apache/aurora/e2e/test_run.sh

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-02 Thread Joe Smith
On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote: src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23 https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23 aurora job run? Kevin and Toby, can you two take a look at this ASAP? I'd like to have the e2e tests fixed

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/ --- (Updated Sept. 2, 2014, 9:06 p.m.) Review request for Aurora, Kevin Sweeney,

Review Request 25285: Upgrade to latest in jetty 7.x series.

2014-09-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25285/ --- Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: