Re: Review Request 25807: Fix the default values for min/max time running while updating

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25807/#review53929 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 19, 2014, 12:27 a

Re: Review Request 25807: Fix the default values for min/max time running while updating

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25807/#review53919 --- Ship it! Ship It! - Bill Farner On Sept. 19, 2014, 12:27 a.m., D

Review Request 25812: Implementing quota checking for async job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/ --- Review request for Aurora, David McLaughlin and Bill Farner. Repository: aurora

Review Request 25807: Fix the default values for min/max time running while updating

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25807/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: auror

Re: Review Request 25794: Add a mock scheduler client to the AuroraClient service

> On Sept. 18, 2014, 9:53 p.m., Joshua Cohen wrote: > > I don't love the idea of shipping a mock alongside production code. > > > > Is there any way we can separate this out so that it's not included for > > prod (i.e. pull it out of services.js and into a file that's only included > > when ru

Re: Review Request 25794: Add a mock scheduler client to the AuroraClient service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25794/#review53879 --- I don't love the idea of shipping a mock alongside production code.

Review Request 25794: Add a mock scheduler client to the AuroraClient service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25794/ --- Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and B

Re: Review Request 25721: Asynchronous JS for Scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25721/#review53874 --- Ship it! Ship It! - Kevin Sweeney On Sept. 18, 2014, 2:29 p.m.,

Re: Review Request 25721: Asynchronous JS for Scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25721/ --- (Updated Sept. 18, 2014, 9:29 p.m.) Review request for Aurora, Joshua Cohen, Ke

Re: Review Request 25791: Save instance update events when updating a job.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/#review53873 --- Ship it! Ship It! - David McLaughlin On Sept. 18, 2014, 8:54 p.m

Re: Review Request 25791: Save instance update events when updating a job.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/ --- (Updated Sept. 18, 2014, 8:54 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25791: Save instance update events when updating a job.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/#review53870 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 18, 2014, 8:48 p.

Re: Review Request 25791: Save instance update events when updating a job.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/ --- (Updated Sept. 18, 2014, 8:48 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25791: Save instance update events when updating a job.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/ --- (Updated Sept. 18, 2014, 8:45 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25791: Save instance update events when updating a job.

> On Sept. 18, 2014, 8:42 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > line 447 > > > > > > Do we have any sort of guidelines on using Preconditions

Re: Review Request 25791: Save instance update events when updating a job.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/#review53867 --- src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControll

Re: Review Request 25750: Store new task configuration in JobUpdateConfiguration as InstanceTaskConfig

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25750/ --- (Updated Sept. 18, 2014, 8:37 p.m.) Review request for Aurora, David McLaughlin

Review Request 25791: Save instance update events when updating a job.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs: AURORA

Re: Review Request 25750: Store new task configuration in JobUpdateConfiguration as InstanceTaskConfig

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25750/#review53860 --- Ship it! Ship It! - David McLaughlin On Sept. 17, 2014, 8:40 p.m

Re: Review Request 25760: Performance improvements and instrumentation for snapshot

> On Sept. 17, 2014, 5:56 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java, line 152 > > > > > > Technically, the outBytes may already be disposed at this point. Move > >

Re: Review Request 25760: Performance improvements and instrumentation for snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25760/ --- (Updated Sept. 18, 2014, 12:57 p.m.) Review request for Aurora, Maxim Khutornen

Re: Review Request 25760: Performance improvements and instrumentation for snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25760/ --- (Updated Sept. 18, 2014, 12:45 p.m.) Review request for Aurora, Maxim Khutornen

Re: Review Request 25760: Performance improvements and instrumentation for snapshot

> On Sept. 18, 2014, 12:56 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java, line 152 > > > > > > Technically, the outBytes may already be disposed at this point. Move >

Re: Review Request 25760: Performance improvements and instrumentation for snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25760/ --- (Updated Sept. 18, 2014, 11:13 a.m.) Review request for Aurora, Maxim Khutornen

Re: Review Request 25760: Performance improvements and instrumentation for snapshot

> On Sept. 17, 2014, 5:56 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java, line 152 > > > > > > Technically, the outBytes may already be disposed at this point. Move > >

Re: Review Request 25753: Surface instance update status changes so they may be persisted.

> On Sept. 17, 2014, 9:04 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java, line 45 > > > > > > Missing xml docs for public methods. > > Bill Farner wrote: > We u

Re: Review Request 25753: Surface instance update status changes so they may be persisted.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25753/ --- (Updated Sept. 18, 2014, 5:12 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25753: Surface instance update status changes so they may be persisted.

> On Sept. 17, 2014, 9:04 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java, > > line 202 > > > > > > Static import for SideEffect.InstanceUpdateStatus.WORKING?