Re: Review Request 26288: Fixing log_response in context.py

2014-10-07 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/#review55650 --- Ship it! Looks good, thanks for changing the approach. Can you

Review Request 26417: Change JSON result of job status when job isn't found.

2014-10-07 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-803

Re: Review Request 26417: Change JSON result of job status when job isn't found.

2014-10-07 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/#review55663 --- Ship it! Ship It! - David McLaughlin On Oct. 7, 2014, 5:12

Re: Review Request 26417: Change JSON result of job status when job isn't found.

2014-10-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/#review55664 --- Ship it! Ship It! - Zameer Manji On Oct. 7, 2014, 10:12 a.m.,

Review Request 26422: Drop syncrhonized from JobUpdateEventSubscriber

2014-10-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26422/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-801

Review Request 26424: Disable requests http connection logging.

2014-10-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/ --- Review request for Aurora, Joe Smith and Bill Farner. Bugs: AURORA-770

Re: Review Request 26424: Disable requests http connection logging.

2014-10-07 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review55698 --- Ship it! src/test/python/apache/aurora/common/test_transport.py

Re: Review Request 26422: Drop syncrhonized from JobUpdateEventSubscriber

2014-10-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26422/#review55700 --- Ship it! Ship It! - Zameer Manji On Oct. 7, 2014, 12:28 p.m.,

Re: Review Request 26424: Disable requests http connection logging.

2014-10-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/ --- (Updated Oct. 7, 2014, 8:32 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55712 --- src/test/python/apache/aurora/client/cli/test_api_from_cli.py

Re: Review Request 26383: Health Check Disabler

2014-10-07 Thread Brian Wickman
On Oct. 6, 2014, 10:40 p.m., Brian Wickman wrote: docs/configuration-reference.md, lines 359-360 https://reviews.apache.org/r/26383/diff/1/?file=714257#file714257line359 Is there any reason this needs to be configurable? Why not just hardcode the filename as '.healthchecksnooze'

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-07 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55717 --- Ship it! Ship It! - Mark Chu-Carroll On Oct. 4, 2014, 1:55

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-07 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55716 --- Looks good. One note on the change description: I'm willing to bet

Review Request 26425: Fixing quota checking for updates.

2014-10-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26425/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-802

Re: Review Request 26288: Fixing unhandled error logging in updater

2014-10-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/ --- (Updated Oct. 7, 2014, 10:26 p.m.) Review request for Aurora and Mark

Review Request 26428: Fixing python style violations.

2014-10-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26428/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description

Re: Review Request 26424: Disable requests http connection logging.

2014-10-07 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review55727 --- Ship it! Aha, here we go. Thanks!! - Joe Smith On Oct. 7, 2014,

Re: Review Request 26428: Fixing python style violations.

2014-10-07 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26428/#review55729 --- build-support/hooks/pre-commit

Re: Review Request 26428: Fixing python style violations.

2014-10-07 Thread Maxim Khutornenko
On Oct. 7, 2014, 11:31 p.m., Brian Wickman wrote: build-support/hooks/pre-commit, line 41 https://reviews.apache.org/r/26428/diff/1/?file=714987#file714987line41 the reason i didn't add this to the pre-commit is beause the default behavior for the pre-commit hook is to only check

Review Request 26430: Remove deprecated configuration options.

2014-10-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/ --- Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.

Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/ --- Review request for Aurora, Joe Smith and Mark Chu-Carroll. Bugs: AURORA-806

Re: Review Request 26432: Reject new GC tasks when shutting down

2014-10-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26432/ --- (Updated Oct. 7, 2014, 5:14 p.m.) Review request for Aurora and Brian Wickman.

Re: Review Request 26428: Fixing python style violations.

2014-10-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26428/ --- (Updated Oct. 8, 2014, 12:17 a.m.) Review request for Aurora and Brian

Re: Review Request 26328: Improve handling of unknown errors in the aurora client.

2014-10-07 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review55749 --- Ship it! Ship It! - David McLaughlin On Oct. 6, 2014, 6:55

Re: Review Request 26324: Increase timeout for PyPI HTTP fetches.

2014-10-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/#review55750 --- Ping Kevin. - Zameer Manji On Oct. 6, 2014, 12:02 p.m., Zameer

Re: Review Request 26333: Add exit status contract between thermos runner and aurora executor.

2014-10-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26333/#review55751 --- Ship it! Ship It! - Kevin Sweeney On Oct. 6, 2014, 11:12 a.m.,