Re: Review Request 27084: Fix error when job create is called with --open-browser.

2014-10-27 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27084/ --- (Updated Oct. 27, 2014, 11:07 a.m.) Review request for Aurora, David

Re: Review Request 22457: Improve aurora job diff command.

2014-10-27 Thread Mark Chu-Carroll
On Oct. 24, 2014, 11:58 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 311 https://reviews.apache.org/r/22457/diff/10/?file=732192#file732192line311 This is no longer true. The `populated` field reprsents a single TaskConfig now. You'd need

Re: Review Request 22457: Improve aurora job diff command.

2014-10-27 Thread Maxim Khutornenko
On Oct. 24, 2014, 3:58 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 311 https://reviews.apache.org/r/22457/diff/10/?file=732192#file732192line311 This is no longer true. The `populated` field reprsents a single TaskConfig now. You'd need

Re: Review Request 22457: Improve aurora job diff command.

2014-10-27 Thread Mark Chu-Carroll
On Oct. 24, 2014, 11:58 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 311 https://reviews.apache.org/r/22457/diff/10/?file=732192#file732192line311 This is no longer true. The `populated` field reprsents a single TaskConfig now. You'd need

Re: Review Request 27188: Use ship-it instead of +/-1.

2014-10-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27188/ --- (Updated Oct. 27, 2014, 5:55 p.m.) Review request for Aurora and Maxim

Re: Review Request 27188: Use ship-it instead of +/-1.

2014-10-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27188/#review58638 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 27, 2014, 5:55

Re: Review Request 22457: Improve aurora job diff command.

2014-10-27 Thread Maxim Khutornenko
On Oct. 24, 2014, 3:58 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 311 https://reviews.apache.org/r/22457/diff/10/?file=732192#file732192line311 This is no longer true. The `populated` field reprsents a single TaskConfig now. You'd need

Re: Review Request 27082: Make job create return an error if the job wasn't created successfully.

2014-10-27 Thread Alex Levenson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27082/#review58647 --- Does this only log the error, or does the exit code change to

Re: Review Request 27082: Make job create return an error if the job wasn't created successfully.

2014-10-27 Thread Zameer Manji
On Oct. 27, 2014, 11:34 a.m., Alex Levenson wrote: Does this only log the error, or does the exit code change to non-zero as well? If it's only logged, maybe the `aurora job create` command should also support the --write-json argument and log the error in json? Thanks, Alex

Re: Review Request 27182: Add a test for the thermos resource module

2014-10-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/#review58668 --- src/test/python/apache/thermos/monitoring/test_resource.py

Re: Review Request 27182: Add a test for the thermos resource module

2014-10-27 Thread Joe Smith
On Oct. 27, 2014, 12:46 p.m., Kevin Sweeney wrote: src/test/python/apache/thermos/monitoring/test_resource.py, line 64 https://reviews.apache.org/r/27182/diff/1/?file=733141#file733141line64 patching a private method assumes intimate knowledge of the class under test and suggests

Review Request 27249: Raise .auroraversion to 0.6.0-SNAPSHOT.

2014-10-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27249/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-711

Re: Review Request 27249: Raise .auroraversion to 0.6.0-SNAPSHOT.

2014-10-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27249/#review58696 --- Ship it! Ship It! - Kevin Sweeney On Oct. 27, 2014, 2:55 p.m.,

Re: Review Request 27249: Raise .auroraversion to 0.6.0-SNAPSHOT.

2014-10-27 Thread Bill Farner
On Oct. 27, 2014, 10:20 p.m., Aurora ReviewBot wrote: Master (c2fdea5) is red with this patch. ./build-support/jenkins/build.sh pants build (options) [spec] (build args) pants build (options) [spec]... -- (build args) Options: --version show program's

Re: Review Request 27044: Make executor overhead configurable

2014-10-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/ --- (Updated Oct. 27, 2014, 4:03 p.m.) Review request for Aurora, Maxim

Re: Review Request 27044: Make executor overhead configurable

2014-10-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/#review58714 --- I couldn't figure out how to use FactoryModuleBuilder in a clean

Review Request 27253: Raise .auroraversion to 0.6.0-SNAPSHOT

2014-10-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27253/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-711

Re: Review Request 27253: Raise .auroraversion to 0.6.0-SNAPSHOT

2014-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27253/#review58726 --- Ship it! Master (c2fdea5) is green with this patch.

Re: Review Request 27253: Raise .auroraversion to 0.6.0-SNAPSHOT

2014-10-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27253/#review58732 --- Ship it! Ship It! - Kevin Sweeney On Oct. 27, 2014, 4:25 p.m.,

Re: Review Request 27044: Make executor overhead configurable

2014-10-27 Thread Bill Farner
On Oct. 22, 2014, 10:07 p.m., Bill Farner wrote: config/legacy_untested_classes.txt, line 9 https://reviews.apache.org/r/27044/diff/1/?file=728771#file728771line9 In the interest of this file being delete only, can you bite the bullet and create a unit test to cover these in a

Re: Review Request 27258: Make job key backfilling more robust.

2014-10-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27258/#review58739 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 28, 2014, 12:44

Re: Review Request 27044: Make executor overhead configurable

2014-10-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/#review58742 --- src/main/java/org/apache/aurora/scheduler/ExecutorOptions.java

Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-899

Re: Review Request 27253: Raise .auroraversion to 0.6.0-SNAPSHOT

2014-10-27 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27253/#review58750 --- why is this not being handled via the release scripts? - Jake

Re: Review Request 27253: Raise .auroraversion to 0.6.0-SNAPSHOT

2014-10-27 Thread Jake Farrell
On Oct. 28, 2014, 1:48 a.m., Jake Farrell wrote: why is this not being handled via the release scripts? ignore, know the reasoning (minor vs major updated during last 0.5.0rc) - Jake --- This is an automatically generated e-mail. To

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

2014-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/#review58754 --- Master (9fb2ce4) is red with this patch.

Review Request 27266: Fixing transient error message formatting in scheduler_client.py

2014-10-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27266/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-900

Re: Review Request 27266: Fixing transient error message formatting in scheduler_client.py

2014-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27266/#review58761 --- Ship it! Master (9fb2ce4) is green with this patch.