---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27084/
---
(Updated Oct. 27, 2014, 11:07 a.m.)
Review request for Aurora, David
On Oct. 24, 2014, 11:58 a.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/jobs.py, line 311
https://reviews.apache.org/r/22457/diff/10/?file=732192#file732192line311
This is no longer true. The `populated` field reprsents a single
TaskConfig now. You'd need
On Oct. 24, 2014, 3:58 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/jobs.py, line 311
https://reviews.apache.org/r/22457/diff/10/?file=732192#file732192line311
This is no longer true. The `populated` field reprsents a single
TaskConfig now. You'd need
On Oct. 24, 2014, 11:58 a.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/jobs.py, line 311
https://reviews.apache.org/r/22457/diff/10/?file=732192#file732192line311
This is no longer true. The `populated` field reprsents a single
TaskConfig now. You'd need
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/
---
(Updated Oct. 27, 2014, 5:55 p.m.)
Review request for Aurora and Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/#review58638
---
Ship it!
Ship It!
- Maxim Khutornenko
On Oct. 27, 2014, 5:55
On Oct. 24, 2014, 3:58 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/jobs.py, line 311
https://reviews.apache.org/r/22457/diff/10/?file=732192#file732192line311
This is no longer true. The `populated` field reprsents a single
TaskConfig now. You'd need
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27082/#review58647
---
Does this only log the error, or does the exit code change to
On Oct. 27, 2014, 11:34 a.m., Alex Levenson wrote:
Does this only log the error, or does the exit code change to non-zero as
well?
If it's only logged, maybe the `aurora job create` command should also
support the --write-json argument and log the error in json?
Thanks,
Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review58668
---
src/test/python/apache/thermos/monitoring/test_resource.py
On Oct. 27, 2014, 12:46 p.m., Kevin Sweeney wrote:
src/test/python/apache/thermos/monitoring/test_resource.py, line 64
https://reviews.apache.org/r/27182/diff/1/?file=733141#file733141line64
patching a private method assumes intimate knowledge of the class under
test and suggests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27249/
---
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-711
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27249/#review58696
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 27, 2014, 2:55 p.m.,
On Oct. 27, 2014, 10:20 p.m., Aurora ReviewBot wrote:
Master (c2fdea5) is red with this patch.
./build-support/jenkins/build.sh
pants build (options) [spec] (build args)
pants build (options) [spec]... -- (build args)
Options:
--version show program's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/
---
(Updated Oct. 27, 2014, 4:03 p.m.)
Review request for Aurora, Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review58714
---
I couldn't figure out how to use FactoryModuleBuilder in a clean
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27253/
---
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-711
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27253/#review58726
---
Ship it!
Master (c2fdea5) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27253/#review58732
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 27, 2014, 4:25 p.m.,
On Oct. 22, 2014, 10:07 p.m., Bill Farner wrote:
config/legacy_untested_classes.txt, line 9
https://reviews.apache.org/r/27044/diff/1/?file=728771#file728771line9
In the interest of this file being delete only, can you bite the bullet
and create a unit test to cover these in a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27258/#review58739
---
Ship it!
Ship It!
- Maxim Khutornenko
On Oct. 28, 2014, 12:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review58742
---
src/main/java/org/apache/aurora/scheduler/ExecutorOptions.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27262/
---
Review request for Aurora and Bill Farner.
Bugs: AURORA-899
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27253/#review58750
---
why is this not being handled via the release scripts?
- Jake
On Oct. 28, 2014, 1:48 a.m., Jake Farrell wrote:
why is this not being handled via the release scripts?
ignore, know the reasoning (minor vs major updated during last 0.5.0rc)
- Jake
---
This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27262/#review58754
---
Master (9fb2ce4) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27266/
---
Review request for Aurora and Bill Farner.
Bugs: AURORA-900
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27266/#review58761
---
Ship it!
Master (9fb2ce4) is green with this patch.
28 matches
Mail list logo