Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61763 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 16, 2014, 10:29

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28097/#review61769 --- I don't see ReadWriteLockManager removal in this diff. It was only

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61816 --- @ReviewBot retry - David McLaughlin On Nov. 16, 2014, 10:29

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61815 --- Ship it! Ship It! - David McLaughlin On Nov. 16, 2014, 10:29

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-17 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61818 --- Ship it!

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61821 --- Master (c44aa5c) is red with this patch.

Re: Review Request 28066: Fixing flaky test.

2014-11-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28066/#review61835 --- Ship it! Ship It! - Kevin Sweeney On Nov. 14, 2014, 5:53 p.m.,

Review Request 28140: Drop argparse dependency; it's part of python 2.7

2014-11-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28140/ --- Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs:

Re: Review Request 28140: Drop argparse dependency; it's part of python 2.7

2014-11-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28140/#review61840 --- Ship it! Ship It! - Kevin Sweeney On Nov. 17, 2014, 4:29 p.m.,

Re: Review Request 28140: Drop argparse dependency; it's part of python 2.7

2014-11-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28140/#review61843 --- Master (c44aa5c) is green with this patch.