Re: Review Request 28449: Fix some URLs and text in release emails to include -incubating where appropriate.

2014-12-02 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28449/#review63560 --- Ship it! Ship It! - Jake Farrell On Nov. 25, 2014, 9 p.m., Bill

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Bill Farner
On Dec. 2, 2014, 2:35 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java, line 71 https://reviews.apache.org/r/28572/diff/1/?file=779239#file779239line71 Please, drop the now unused TASK_TO_SLAVE_ID. Thanks, made a

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/ --- (Updated Dec. 2, 2014, 7:04 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/#review63562 --- Ship it! Master (d476e2a) is green with this patch.

Review Request 28605: Don't intercept methods on thrift that don't return Response.

2014-12-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28605/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-952

Re: Review Request 28605: Don't intercept methods on thrift that don't return Response.

2014-12-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28605/#review63563 --- Ship it! Thanks!! - Bill Farner On Dec. 2, 2014, 7:20 p.m.,

Re: Review Request 28605: Don't intercept methods on thrift that don't return Response.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28605/#review63564 --- Ship it! Master (d476e2a) is green with this patch.

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Bill Farner
On Dec. 2, 2014, 7:30 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java, line 67 https://reviews.apache.org/r/28572/diff/2/?file=780331#file780331line67 Citation needed? Iterables.transform generates a lazy view.

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/#review63574 --- Ship it! Ship It! - Kevin Sweeney On Dec. 2, 2014, 11:04 a.m.,

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

2014-12-02 Thread Kevin Sweeney
On Dec. 2, 2014, 11:30 a.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java, line 67 https://reviews.apache.org/r/28572/diff/2/?file=780331#file780331line67 Citation needed? Iterables.transform generates a lazy view.

Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs:

Re: Review Request 28486: Move sandbox initialization into try block.

2014-12-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28486/#review63587 --- src/main/python/apache/aurora/executor/aurora_executor.py

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63596 --- Ship it! Master (c86ca6d) is green with this patch.

Review Request 28610: Use requirements.txt for 3rdparty/python.

2014-12-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28610/ --- Review request for Aurora, Joshua Cohen and Brian Wickman. Bugs: AURORA-617

Re: Review Request 28610: Use requirements.txt for 3rdparty/python.

2014-12-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28610/#review63599 --- 3rdparty/python/BUILD

Re: Review Request 28610: Use requirements.txt for 3rdparty/python.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28610/#review63600 --- Master (c86ca6d) is green with this patch.

Re: Review Request 28610: Use requirements.txt for 3rdparty/python.

2014-12-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28610/#review63601 --- Ship it! wfm, modulo zameer's comment. - Brian Wickman On Dec.

Re: Review Request 28610: Use requirements.txt for 3rdparty/python.

2014-12-02 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28610/#review63603 --- Ship it! Ship It! - Joshua Cohen On Dec. 2, 2014, 10:32 p.m.,

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63598 ---

Re: Review Request 28610: Use requirements.txt for 3rdparty/python.

2014-12-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28610/ --- (Updated Dec. 2, 2014, 3:09 p.m.) Review request for Aurora, Joshua Cohen and

Review Request 28613: Updates documentation README to re-organize around three audiences, and add links to all current documentation pages.

2014-12-02 Thread Dave Lester
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28613/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 28613: Updates documentation README to re-organize around three audiences, and add links to all current documentation pages.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28613/#review63608 --- Ship it! Master (552ae93) is green with this patch.

Review Request 28617: Implemented offer filtering for tasks with static vetoes.

2014-12-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28617/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-909

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Bill Farner
On Dec. 2, 2014, 11:09 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, line 52 https://reviews.apache.org/r/28607/diff/1/?file=780416#file780416line52 minor nit: you might want to have it outside the synchronized

Re: Review Request 28613: Updates documentation README to re-organize around three audiences, and add links to all current documentation pages.

2014-12-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28613/#review63620 --- Ship it! This is awesome thanks!! - Bill Farner On Dec. 2,

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Maxim Khutornenko
On Dec. 2, 2014, 11:09 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, line 58 https://reviews.apache.org/r/28607/diff/1/?file=780416#file780416line58 Would it make sense to do it conditionally, i.e.: ```java

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28617/#review63627 --- Ship it! Master (552ae93) is green with this patch.

Review Request 28621: Prevent Aurora from creating tasks with 0 disk.

2014-12-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-956

Re: Review Request 28621: Prevent Aurora from creating tasks with 0 disk.

2014-12-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/#review63628 --- Ship it!

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Bill Farner
On Dec. 2, 2014, 11:09 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, line 58 https://reviews.apache.org/r/28607/diff/1/?file=780416#file780416line58 Would it make sense to do it conditionally, i.e.: ```java

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/ --- (Updated Dec. 3, 2014, 1:39 a.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 28621: Prevent Aurora from creating tasks with 0 disk.

2014-12-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/ --- (Updated Dec. 2, 2014, 5:43 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 28621: Prevent Aurora from creating tasks with 0 disk.

2014-12-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/ --- (Updated Dec. 2, 2014, 5:45 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63632 --- Ship it! Master (552ae93) is green with this patch.

Re: Review Request 28621: Prevent Aurora from creating tasks with 0 disk.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/#review63633 --- Ship it! Master (552ae93) is green with this patch.

Re: Review Request 28621: Prevent Aurora from creating tasks with 0 disk.

2014-12-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28621/#review63634 --- Ship it! This is now on master: ``` $ git log -1 origin/master

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63637 --- Ship it!

Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

2014-12-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28623/ --- Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs:

Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

2014-12-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28623/#review63638 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 3, 2014, 2:13

Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28623/#review63639 --- Ship it! Master (8959b49) is green with this patch.