twitter.common.zookeeper-0.3.3-py2-none-any.whl
watchdog-0.7.0-cp27-none-macosx_10_9_intel.whl
zope.interface-4.1.2-cp27-none-macosx_10_9_intel.whl
Thanks,
Brian Wickman
/thermos/monitoring/disk.py
ccf6d6aafe893836e72e179cc1a8010a1ac6ac7f
src/test/python/apache/thermos/monitoring/test_disk.py
e1373234feba08ab881179af0cbf6b7ed326cc45
Diff: https://reviews.apache.org/r/32515/diff/
Testing
---
Thanks,
Brian Wickman
/diff/
Testing
---
Thanks,
Brian Wickman
/thermos/monitoring/test_disk.py
e1373234feba08ab881179af0cbf6b7ed326cc45
Diff: https://reviews.apache.org/r/32515/diff/
Testing
---
Thanks,
Brian Wickman
-macosx_10_9_intel.whl
Thanks,
Brian Wickman
-0.3.3-py2-none-any.whl
watchdog-0.7.0-cp27-none-macosx_10_9_intel.whl
zope.interface-4.1.2-cp27-none-macosx_10_9_intel.whl
Thanks,
Brian Wickman
FAILURE[0m
I will refresh this build result if you post a review containing
@ReviewBot retry
Brian Wickman wrote:
welp
my kingdom for reviewbot to print out stderr logs
- Brian
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32221/#review76992
---
@ReviewBot retry
- Brian Wickman
On March 19, 2015, 1:20 a.m
---
Cannot reproduce locally, but 5 seconds is an impossibly small timeout, even if
we aren't testing SIGTERM swallowing. If this fails, we will get tripped by
60s timeout instead.
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32221/#review76998
---
@ReviewBot retry
- Brian Wickman
On March 19, 2015, 1:20 a.m
/r/32221/diff/
Testing
---
Cannot reproduce locally, but 5 seconds is an impossibly small timeout, even if
we aren't testing SIGTERM swallowing. If this fails, we will get tripped by
60s timeout instead.
Thanks,
Brian Wickman
.
- Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32013/#review76784
---
On March 17, 2015, 8:24 p.m., Brian Wickman wrote
,
Brian Wickman
://reviews.apache.org/r/32131/#comment124315
only a minor concern that people depend on this, but it's probably ok to
remove.
- Brian Wickman
On March 16, 2015, 10:18 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32012/#review76586
---
@ReviewBot retry
- Brian Wickman
On March 13, 2015, 7:38 p.m
://reviews.apache.org/r/32013/diff/
Testing
---
./pants test src/test/python/apache/thermos/observer:: + manual observation
Thanks,
Brian Wickman
://reviews.apache.org/r/32013/diff/
Testing
---
./pants test src/test/python/apache/thermos/observer:: + manual observation
Thanks,
Brian Wickman
On March 13, 2015, 1:10 a.m., Brian Wickman wrote:
@ReviewBot retry
Bill Farner wrote:
If you believe you have discovered a flaky test (which i assume you're
asking the bot to try again), can you please file a ticket?
Not a flaky test -- a legitimate breakage that I did
e9005c402ec81bbb415d9c814aa7b4e759138304
Diff: https://reviews.apache.org/r/32012/diff/
Testing
---
Added generic TaskDetector test and made sure it passes before/after.
Thanks,
Brian Wickman
/
Testing
---
./pants test src/test/python/apache/thermos/observer:: + manual observation
Thanks,
Brian Wickman
tests.
- Brian Wickman
On March 13, 2015, 12:48 a.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32013
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32012/#review76322
---
@ReviewBot retry
- Brian Wickman
On March 13, 2015, 12:47 a.m
On Feb. 6, 2015, 6:52 p.m., Brian Wickman wrote:
This is super rad. Thanks for taking this on.
Before I do a deeper dive, what do you think about making the logrotate
policy be specified by the user instead of the framework owner, with a
sensible default? For example
-CREATION
src/main/python/apache/thermos/observer/task_observer.py
6e7517b9f1b70cef8b0400cd7769fbbe7495dc42
Diff: https://reviews.apache.org/r/31774/diff/
Testing
---
mba=aurora=; ./pants test.pytest --no-fast src/test3/python::
Thanks,
Brian Wickman
-CREATION
src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION
src/test/python/apache/thermos/cli/test_common.py PRE-CREATION
Diff: https://reviews.apache.org/r/31559/diff/
Testing
---
./pants test src/test/python/apache/thermos/cli::
Thanks,
Brian Wickman
---
On March 3, 2015, 10:14 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559
src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION
src/test/python/apache/thermos/cli/test_common.py PRE-CREATION
Diff: https://reviews.apache.org/r/31559/diff/
Testing
---
./pants test src/test/python/apache/thermos/cli::
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74709
---
On Feb. 27, 2015, 11:36 p.m., Brian Wickman wrote:
---
This is an automatically generated e
: https://reviews.apache.org/r/31451/diff/
Testing
---
Manually launched observer and ran some thermos tasks.
+
mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
Thanks,
Brian Wickman
-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review75063
---
On March 3, 2015, 10:14 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply
://reviews.apache.org/r/31559/diff/
Testing
---
./pants test src/test/python/apache/thermos/cli::
Thanks,
Brian Wickman
-CREATION
Diff: https://reviews.apache.org/r/31559/diff/
Testing
---
./pants test src/test/python/apache/thermos/cli::
Thanks,
Brian Wickman
/31559/diff/
Testing
---
./pants test src/test/python/apache/thermos/cli::
Thanks,
Brian Wickman
src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
Diff: https://reviews.apache.org/r/31451/diff/
Testing
---
Manually launched observer and ran some thermos tasks.
+
mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31491/#review74343
---
On Feb. 26, 2015, 7:20 p.m., Brian Wickman wrote:
---
This is an automatically generated
://reviews.apache.org/r/31491/#comment120949
Thanks for the catch.
- Brian Wickman
On Feb. 26, 2015, 8 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31491
test.pytest --no-fast --options='-vs'
src/test/python/apache/aurora/executor/common:health_checker
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30749/#review73337
---
@Reviewbot retry
- Brian Wickman
On Feb. 20, 2015, 7:06 p.m
sure
- Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review73324
---
On Feb. 20, 2015, 7:33 p.m., Brian Wickman wrote
, 2015, 1:09 a.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/
---
(Updated Feb. 21, 2015, 1:09 a.m
://reviews.apache.org/r/31251/diff/
Testing
---
Ran the following about 100 times:
THERMOS_DEBUG=1 ./pants test.pytest --no-fast --options='-vs'
src/test/python/apache/aurora/executor/common:health_checker
Thanks,
Brian Wickman
:
https://reviews.apache.org/r/30749/#review71833
---
On Feb. 20, 2015, 7:06 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30749/#review71831
---
On Feb. 9, 2015, 11:16 p.m., Brian Wickman wrote
On Feb. 20, 2015, 11:11 p.m., Brian Wickman wrote:
@Reviewbot retry
Bill Farner wrote:
Is that test known to be flaky? If so, can you file a ticket?
https://reviews.apache.org/r/30647/ should deflake it.
- Brian
c8fab307d17949a8157659c4b3944ec7520feb9d
Diff: https://reviews.apache.org/r/30647/diff/
Testing
---
./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31138/#review72840
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 17, 2015, 11:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31124/#review72752
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 17, 2015, 6:09 p.m
://reviews.apache.org/r/31137/diff/
Testing
---
./pants test.pytest --no-fast src/test/python::
Thanks,
Brian Wickman
---
./pants test.pytest --no-fast src/main/python::
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30768/#review71649
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 8, 2015, 9:34 p.m
/aurora/executor/test_gc_executor.py
b1bbc89a822302d8ea12324eb767631326639ebb
Diff: https://reviews.apache.org/r/30749/diff/
Testing
---
./pants test.pytest --no-fast src/main/python::
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30749/#review71567
---
On Feb. 7, 2015, 2:27 a.m., Brian Wickman wrote
,
Brian Wickman
/main/python::
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71711
---
ping.
- Brian Wickman
On Feb. 6, 2015, 11:13 p.m., Brian Wickman
/test_thermos_executor_entry_point.py
PRE-CREATION
src/test/python/apache/aurora/executor/test_gc_executor.py
b1bbc89a822302d8ea12324eb767631326639ebb
Diff: https://reviews.apache.org/r/30749/diff/
Testing
---
./pants test.pytest --no-fast src/main/python::
Thanks,
Brian Wickman
://reviews.apache.org/r/27182/#comment117267
these aren't explicitly covered by your BUILD target
src/test/python/apache/thermos/monitoring/test_resource.py
https://reviews.apache.org/r/27182/#comment117268
ditto re: coverage
- Brian Wickman
On Feb. 6, 2015, 10 p.m., Joe Smith wrote
this with master and
re-publish so that I can patch to master?
- Brian Wickman
On Feb. 6, 2015, 10 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182
---
Built the binaries.
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review71522
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 6, 2015, 10 p.m., Joe
: https://reviews.apache.org/r/30749/diff/
Testing
---
./pants test.pytest --no-fast src/main/python::
Thanks,
Brian Wickman
69bf8e4c2e2e5f85f6b822fbe45f828d61814d7f
src/test/python/apache/aurora/executor/test_gc_executor.py
b1bbc89a822302d8ea12324eb767631326639ebb
Diff: https://reviews.apache.org/r/30749/diff/
Testing
---
./pants test.pytest --no-fast src/main/python::
Thanks,
Brian Wickman
c8fab307d17949a8157659c4b3944ec7520feb9d
Diff: https://reviews.apache.org/r/30647/diff/
Testing
---
./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
on its deathbed
as soon Mesos will have disk enforcement built in.
- Brian Wickman
On Feb. 6, 2015, 7:59 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182
::
Thanks,
Brian Wickman
://reviews.apache.org/r/30741/#review71505
---
On Feb. 6, 2015, 7:30 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
/thermos/monitoring::
One failure due to incompatible merge w/ r/30704 -- will send follow up patch.
Thanks,
Brian Wickman
/aurora/executor/test_gc_executor.py
b1bbc89a822302d8ea12324eb767631326639ebb
Diff: https://reviews.apache.org/r/30749/diff/
Testing
---
./pants test.pytest --no-fast src/main/python::
Thanks,
Brian Wickman
On Feb. 6, 2015, 6:52 p.m., Brian Wickman wrote:
This is super rad. Thanks for taking this on.
Before I do a deeper dive, what do you think about making the logrotate
policy be specified by the user instead of the framework owner, with a
sensible default? For example
/executor/test_thermos_executor.py
c8fab307d17949a8157659c4b3944ec7520feb9d
Diff: https://reviews.apache.org/r/30647/diff/
Testing
---
./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
patch.
Thanks,
Brian Wickman
, class
constructors, etc. And if you ever need to add new features (e.g. a compress
option), they're fairly well encapsulated within the Logger union.
- Brian Wickman
On Feb. 6, 2015, 5:51 p.m., George Sirois wrote
/monitoring::
One failure due to incompatible merge w/ r/30704 -- will send follow up patch.
Thanks,
Brian Wickman
of the 'enabled' flags.
will fix.
- Brian Wickman
On Feb. 5, 2015, 7:17 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30650/#review71453
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 5, 2015, 4:13 a.m
---
./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
---
./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30704/#review71352
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 6, 2015, 1:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/#review71284
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 5, 2015, 4:13 a.m
/aurora/executor/common::
Thanks,
Brian Wickman
/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
def249c2509a28f7145380f250f79202b653dc83
Diff: https://reviews.apache.org/r/30647/diff/
Testing
---
./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review70419
---
Ship it!
Ship It!
- Brian Wickman
On Jan. 28, 2015, 8:26 p.m
of it, but
I'm not sure what was broken or what is being improved.)
- Brian Wickman
On Dec. 20, 2014, 3:05 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29286
://reviews.apache.org/r/30187/#comment114399
wait -- the # noqa is necessary, otherwise checkstyle will fail.
- Brian Wickman
On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit
/r/28920/#comment114180
sort of higher-level question -- since this information is not used by
thermos at all, does it make sense in
src/main/python/apache/aurora/config/schema/base.py instead? usually Aurora
concerns are in Job() and Thermos concerns are in Task().
- Brian Wickman
/apache/aurora/executor/thermos_task_runner.py
https://reviews.apache.org/r/28920/#comment114201
os.environ.get('MESOS_DIRECTORY')
(i worry that cwd='.' will actually break something, whereas cwd=None will
be a no-op.)
- Brian Wickman
On Jan. 24, 2015, midnight, Steve Niemitz wrote
in order to reduce
redundancy, similar to pystachio.
The way the code is currently structured, YAML will still work fine if it's
available in the environmenet of your Aurora client, and gracefully fall back
if not.
Thoughts?
- Brian Wickman
On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote
defaults to
os.path.join(sandbox, '.logs'), so the log_dir part here is unnecessary.
- Brian Wickman
On Jan. 16, 2015, 12:08 a.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Jan. 22, 2015, 10:22 p.m., Brian Wickman wrote:
src/main/python/apache/thermos/core/runner.py, lines 627-632
https://reviews.apache.org/r/28920/diff/18/?file=823218#file823218line627
this is an abstraction leak. grep the thermos codebase for 'aurora'
and 'mesos'. thermos
.
if both the above are true, then we don't need any of the changes to
CommandUtil.
- Brian Wickman
On Jan. 16, 2015, 12:08 a.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java,
lines 153-158
https://reviews.apache.org/r/28920/diff/18/?file=823211#file823211line153
can't the stuff in DOCKER_COMMAND_PREFIX be accomplished
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/#review68961
---
Ship it!
Ship It!
- Brian Wickman
On Jan. 16, 2015, 9:45 p.m
e3c766f9b7bf989c0790281231957947d2cda52a
Diff: https://reviews.apache.org/r/29901/diff/
Testing
---
./pants goal test --no-test-pytest-fast
src/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
---
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Brian Wickman
/aurora/executor/common/test_resource_manager_integration.py
e3c766f9b7bf989c0790281231957947d2cda52a
Diff: https://reviews.apache.org/r/29901/diff/
Testing
---
./pants goal test --no-test-pytest-fast
src/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
e3c766f9b7bf989c0790281231957947d2cda52a
Diff: https://reviews.apache.org/r/29901/diff/
Testing
---
./pants goal test --no-test-pytest-fast
src/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
e3c766f9b7bf989c0790281231957947d2cda52a
Diff: https://reviews.apache.org/r/29901/diff/
Testing
---
./pants goal test --no-test-pytest-fast
src/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
Brian Wickman wrote:
this is to fix the test failure brought up by reviewbot. unclear if it's
related to the pants upgrade, but it should be fixed regardless.
Brian Wickman wrote:
would you prefer that this go into a separate review?
Kevin Sweeney wrote:
Yes, I prefer to keep
e3c766f9b7bf989c0790281231957947d2cda52a
Diff: https://reviews.apache.org/r/29901/diff/
Testing
---
./pants goal test --no-test-pytest-fast
src/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
1 - 100 of 352 matches
Mail list logo
