/http/ui/js/controllers.js
https://reviews.apache.org/r/21523/#comment77304
Why?
- Mark Chu-Carroll
On May 15, 2014, 9:30 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
the updated doc.)
Diffs (updated)
-
docs/clientv2.md PRE-CREATION
Diff: https://reviews.apache.org/r/18979/diff/
Testing
---
n/a
Thanks,
Mark Chu-Carroll
,
Mark Chu-Carroll
src.test.python.apache.aurora.client.hooks.hooked_api
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
Mark Chu-Carroll
tests, that ensure
that calling the new APIs causes the right internal cron methods to be called.)
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21294/#review43002
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 9, 2014, 8:50 p.m
, which will mask a lot of potential error cases.
- Mark Chu-Carroll
On May 14, 2014, 2:49 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440
Chu-Carroll
On May 9, 2014, 2:05 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/
---
(Updated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21205/#review42832
---
Suman, ping?
- Mark Chu-Carroll
On May 8, 2014, 10:26 a.m., Mark
/21383/diff/
Testing
---
Ran all tests with gradlew; no errors. (Includes two new tests, that ensure
that calling the new APIs causes the right internal cron methods to be called.)
Thanks,
Mark Chu-Carroll
Thanks,
Mark Chu-Carroll
/
Testing
---
n/a
Thanks,
Mark Chu-Carroll
-Carroll
On March 21, 2014, 1:58 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18979/
---
(Updated
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
Mark Chu-Carroll
src.test.python.apache.aurora.client.hooks.hooked_api
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
[sun-wukong incubator-aurora (restart_max)] $
Thanks,
Mark Chu-Carroll
)
+ echo '***'
***
+ exit 0
Thanks,
Mark Chu-Carroll
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (shard_errors)]$
Thanks,
Mark Chu-Carroll
be block. All we want to do is let them (and the loggie service) know that
there was a problem with the skip rules. This will get logged to loggie,
because it's got a global handler in place.
- Mark Chu-Carroll
On May 1, 2014, 5:39 p.m., Mark Chu-Carroll wrote
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (command-hooks-two)]$
Thanks,
Mark Chu-Carroll
. SUCCESS
[sun-wukong incubator-aurora (batch_v1)]$
Thanks,
Mark Chu-Carroll
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (command-hooks-two)]$
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21093/#review42230
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 5, 2014, 8:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21020/#review42042
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 2, 2014, 2:55 p.m
: aurora
Description
---
Make --help defer to bridged help in the bridged client executable.
Diffs
-
src/main/python/apache/aurora/client/cli/bridge.py
30f1718456deb30632efb57fd8e04d97f74ad00d
Diff: https://reviews.apache.org/r/21023/diff/
Testing
---
Thanks,
Mark Chu-Carroll
: https://reviews.apache.org/r/21023/diff/
Testing
---
Thanks,
Mark Chu-Carroll
://reviews.apache.org/r/20950/#comment75594
shouldn't this be =?
src/test/python/apache/aurora/client/api/test_job_monitor.py
https://reviews.apache.org/r/20950/#comment75595
You can just assert monitor.wait_until
- Mark Chu-Carroll
On May 1, 2014, 1:01 p.m., Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20950/#review41943
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 1, 2014, 4:42 p.m
---
On April 25, 2014, 3:15 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20723
Chu-Carroll
On May 1, 2014, 4:47 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20928/
---
(Updated
. SUCCESS
[sun-wukong incubator-aurora (command-hooks-two)]$
Thanks,
Mark Chu-Carroll
(command_hooks)]$
Thanks,
Mark Chu-Carroll
-wukong incubator-aurora (command_hooks)]$
Thanks,
Mark Chu-Carroll
(command_hooks)]$
Thanks,
Mark Chu-Carroll
them after the exec returns.
- Mark Chu-Carroll
On April 24, 2014, 8:17 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20687
)]$
Thanks,
Mark Chu-Carroll
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (command_hooks)]$
Thanks,
Mark Chu-Carroll
. SUCCESS
[sun-wukong incubator-aurora (fix_plugins)]$
Thanks,
Mark Chu-Carroll
src.test.python.apache.aurora.client.hooks.hooked_api
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
[sun-wukong incubator-aurora (fix_plugins)]$
Thanks,
Mark Chu-Carroll
. SUCCESS
src.test.python.apache.aurora.client.commands.run
. SUCCESS
src.test.python.apache.aurora.client.commands.ssh
. SUCCESS
[sun-wukong incubator-aurora (batch_v1)]$
Thanks,
Mark Chu-Carroll
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
[sun-wukong incubator-aurora (fix_plugins)]$
Thanks,
Mark Chu-Carroll
On April 24, 2014, 8:15 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 344
https://reviews.apache.org/r/20687/diff/1/?file=567983#file567983line344
Different cases.
A command hook can signal that a command shouldn't be executed
, Mark Chu-Carroll wrote:
Review request for Aurora, David McLaughlin and Suman Karumuri.
By Mark Chu-Carroll.
*Updated April 25, 2014, 12:17 a.m.*
*Bugs: * aurora-270 https://issues.apache.org/jira/browse/aurora-270
*Repository: * aurora
Description
Stage 1 of implementing command hooks
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20726/#review41515
---
Ship it!
Ship It!
- Mark Chu-Carroll
On April 25, 2014, 3:41
that
the command be aborted.
The hook can also signal an exception, which means that there was an error
in the hook.
src/main/python/apache/aurora/client/cli/command_hooks.py
https://reviews.apache.org/r/20687/#comment74858
d'oh.
- Mark Chu-Carroll
On April 24, 2014, 3:30 p.m
. SUCCESS
[sun-wukong incubator-aurora (command_hooks)]$
Thanks,
Mark Chu-Carroll
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
[sun-wukong incubator-aurora (get_version)]$
Thanks,
Mark Chu-Carroll
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (plugin_with_cleanup)]$
Thanks,
Mark Chu-Carroll
'***'
***
+ exit 0
Thanks,
Mark Chu-Carroll
a Context.CommandError. The exception carries
the exit code.
- Mark Chu-Carroll
On April 21, 2014, 9:33 a.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20521
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (plugin_with_cleanup)]$
Thanks,
Mark Chu-Carroll
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (plugin_with_cleanup)]$
Thanks,
Mark Chu-Carroll
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
[sun-wukong incubator-aurora (plugin_with_cleanup)]$
Thanks,
Mark Chu-Carroll
. SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
[sun-wukong incubator-aurora (get_version)]$
Thanks,
Mark Chu-Carroll
. SUCCESS
[sun-wukong incubator-aurora (get_version)]$
Thanks,
Mark Chu-Carroll
of the open command.
Thanks,
Mark Chu-Carroll
/main/python/apache/aurora/client/cli/__init__.py
a1063e1af24fd42adafbeebf757bca4de47db1fc
src/main/python/apache/aurora/client/cli/bridge.py
37964b65b597abcf7f85b414fa5c6473da9f12ed
Diff: https://reviews.apache.org/r/20010/diff/
Testing
---
Manual command-line testing.
Thanks,
Mark Chu
Thanks,
Mark Chu-Carroll
On March 28, 2014, 1:46 p.m., Maxim Khutornenko wrote:
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh, line 43
https://reviews.apache.org/r/19788/diff/1/?file=539838#file539838line43
Why not pushd once instead?
Mark Chu-Carroll wrote:
Don't follow the question. What
+ [[ 0 = 0 ]]
+ echo '***'
***
+ echo 'OK (all tests passed)'
OK (all tests passed)
+ echo '***'
***
+ exit 0
Thanks,
Mark Chu-Carroll
Bill: It's been 24 hours, and I'm still waiting on a clarification request.
Please, can you take a minute, and answer, so that I can get this review
done?
-Mark
On Wed, Mar 26, 2014 at 3:28 PM, Mark Chu-Carroll
mchucarr...@twopensource.com wrote:
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19431/#review38480
---
Ping?
- Mark Chu-Carroll
On March 24, 2014, 2:58 p.m., Mark Chu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19396/#review38481
---
kevin, ping?
- Mark Chu-Carroll
On March 21, 2014, 3:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38484
---
Brian, ping?
- Mark Chu-Carroll
On March 24, 2014, 7:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38489
---
Brian, ping?
- Mark Chu-Carroll
On March 24, 2014, 7:21 p.m
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
Mark Chu-Carroll
, 2014 at 6:22 PM, Brian Wickman wick...@apache.org wrote:
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19431/
On March 24th, 2014, 6:57 p.m. UTC, *Mark Chu-Carroll* wrote:
src/main/python/apache/aurora/client/cli/options.pyhttps
. SUCCESS
Thanks,
Mark Chu-Carroll
src.test.python.apache.aurora.client.cli.quota
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu-Carroll
all was never revealed to users, and we've decided to get rid of it. It
will never show up in a user-visible way; mentioning it here will just be
confusing.
- Mark Chu-Carroll
On March 22, 2014, 10:14 a.m., Mark Chu-Carroll wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38379
---
ping?
- Mark Chu-Carroll
On March 21, 2014, 2:58 p.m., Mark Chu
://reviews.apache.org/r/19466/#comment70485
I did. I screwed up again, uploaded the change to the wrong review. Stupid.
I get completely screwed up when I try to juggle too many open reviews at once.
Sorry.
- Mark Chu-Carroll
On March 21, 2014, 2:58 p.m., Mark Chu-Carroll wrote
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
Mark Chu-Carroll
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu-Carroll
No need for weaselword typically here.
docs/hooks.md
https://reviews.apache.org/r/19313/#comment70062
Tons of trailing whitespace everywhere, and smart quotes for apostrophes.
- Mark Chu-Carroll
On March 17, 2014, 3:01 p.m., Tom Galloway wrote
src.test.python.apache.aurora.client.hooks.hooked_api
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
Mark Chu-Carroll
in this change that
should cause a thermos problem - but I don't know nearly enough about thermos,
so I'll defer to Brian, who's the thermos God.
- Mark Chu-Carroll
On March 20, 2014, 10:39 p.m., Suman Karumuri wrote
/#review38154
---
On March 20, 2014, 11:42 a.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466
for
the people who build/maintain it.
If you think of it that way, I think it's clear when to use which.
- Mark Chu-Carroll
On March 19, 2014, 9:20 a.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail
src.test.python.apache.aurora.client.cli.quota
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19509/#review38205
---
Ship it!
Ship It!
- Mark Chu-Carroll
On March 20, 2014, 10:39
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
Mark Chu-Carroll
. SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
Mark Chu-Carroll
shards: you need to explicitly say that that's what you want to do.
- Mark Chu-Carroll
On March 19, 2014, 7:38 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu-Carroll
src.test.python.apache.aurora.client.cli.quota
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.cli.task
. SUCCESS
Thanks,
Mark Chu
of
boolean, and if they supply an override, then hooks don't run?
- Mark Chu-Carroll
On March 19, 2014, 1:09 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19411
a good idea.)
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19143/#review37080
---
On March 12, 2014, 6:59 p.m., Mark Chu-Carroll
://reviews.apache.org/r/19159/
On March 12th, 2014, 3:25 p.m. PDT, *Mark Chu-Carroll* wrote:
src/main/python/apache/aurora/client/commands/core.pyhttps://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399
(Diff
revision 1)
def show_job_pretty(job):
397
without the --force
flag. The standard optional semantic of that flag is violated here.
On Mar 13, 2014, at 11:07 AM, Mark Chu-Carroll mchucarr...@apache.org
wrote:
I think making a reasonable effort to make it harder to accidentally do
this is worthwhile - there's no harm in it, and it might
==
src.test.python.apache.aurora.client.commands.core
. SUCCESS
Thanks,
Mark Chu-Carroll
==
src.test.python.apache.aurora.client.commands.core
. SUCCESS
Thanks,
Mark Chu-Carroll
==
src.test.python.apache.aurora.client.commands.core
. SUCCESS
Thanks,
Mark Chu-Carroll
..
src/test/python/apache/aurora/client/commands/test_update.py ...
= 26 passed in 11.34 seconds ==
src.test.python.apache.aurora.client.commands.core
. SUCCESS
Thanks,
Mark Chu-Carroll
==
src.test.python.apache.aurora.client.commands.core
. SUCCESS
Thanks,
Mark Chu-Carroll
src.test.python.apache.aurora.client.commands.maintenance
. SUCCESS
src.test.python.apache.aurora.client.commands.run
. SUCCESS
src.test.python.apache.aurora.client.commands.ssh
. SUCCESS
Thanks,
Mark Chu-Carroll
/19143/diff/
Testing
---
Thanks,
Mark Chu-Carroll
-mail. To reply, visit:
https://reviews.apache.org/r/18979/#review36827
---
On March 11, 2014, 12:34 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail
---
n/a
Thanks,
Mark Chu-Carroll
is also in this change - see the change above in kill.
- Mark Chu-Carroll
On March 12, 2014, 6:11 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159
/apache/aurora/client/api/scheduler_client.py
f770df7a23779f919cd11cc28b2aaf7cfdf9c5a1
Diff: https://reviews.apache.org/r/19143/diff/
Testing
---
Thanks,
Mark Chu-Carroll
201 - 300 of 373 matches
Mail list logo
