---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24815/#review52455
---
Ship it!
On Sept. 5, 2014, 3:25 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/state/StateManager.java, line 73
https://reviews.apache.org/r/24815/diff/2/?file=679135#file679135line73
Inserts pending instances using {@code task} as their configuration.
Tasks will...
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24815/
---
(Updated Sept. 5, 2014, 8:26 p.m.)
Review request for Aurora and Bill Farner.
On Sept. 5, 2014, 3:25 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java,
line 47
https://reviews.apache.org/r/24815/diff/2/?file=679138#file679138line47
s/instances/newInstances/?
It would be nice for the parameter name
On Sept. 5, 2014, 3:25 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java,
line 47
https://reviews.apache.org/r/24815/diff/2/?file=679138#file679138line47
s/instances/newInstances/?
It would be nice for the parameter name
On Sept. 2, 2014, 10:36 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java,
line 35
https://reviews.apache.org/r/24815/diff/1/?file=662758#file662758line35
Is this interface useful? The implementation logic is trivial, and
it's
On Sept. 2, 2014, 10:36 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java,
line 35
https://reviews.apache.org/r/24815/diff/1/?file=662758#file662758line35
Is this interface useful? The implementation logic is trivial, and
it's
On Sept. 2, 2014, 10:36 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java,
line 35
https://reviews.apache.org/r/24815/diff/1/?file=662758#file662758line35
Is this interface useful? The implementation logic is trivial, and
it's
On Sept. 2, 2014, 10:36 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java, line
120
https://reviews.apache.org/r/24815/diff/1/?file=662756#file662756line120
At first glance, this is odd since ITaskConfig contains the components
of a
On Sept. 2, 2014, 10:36 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java,
line 35
https://reviews.apache.org/r/24815/diff/1/?file=662758#file662758line35
Is this interface useful? The implementation logic is trivial, and
it's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24815/
---
(Updated Sept. 5, 2014, 12:09 a.m.)
Review request for Aurora and Bill Farner.
On Sept. 2, 2014, 10:36 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java, line
120
https://reviews.apache.org/r/24815/diff/1/?file=662756#file662756line120
At first glance, this is odd since ITaskConfig contains the components
of a
12 matches
Mail list logo
