Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26469/#review56242 --- Ship it! This is now on origin/master. Thanks! $ git log -1

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26469/#review55979 --- Ship it! Ship It! - Bill Farner On Oct. 9, 2014, 12:15 a.m.,

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Bill Farner
On Oct. 9, 2014, 2:32 p.m., Bill Farner wrote: Ship It! Hmm, i'm now getting a different coverage error when preparing to submit this: * What went wrong: Execution failed for task ':jacocoTestReport'. Thanks for adding the first test coverage to:

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Joshua Cohen
Nope, it's passing for me, but it's similar to the behavior I was seeing with ApiBeta$2; even after cleaning the reports directory I was *not* getting the failure about it missing coverage even though it actually was. On Thu, Oct 9, 2014 at 8:32 AM, Bill Farner wfar...@apache.org wrote: This

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Joshua Cohen
I can also verify that running the entire test suite in a debugger, a breakpoint set in OfferQueue$OfferQueueImpl$2 is not hit. On Thu, Oct 9, 2014 at 10:05 AM, Joshua Cohen jco...@twopensource.com wrote: Nope, it's passing for me, but it's similar to the behavior I was seeing with ApiBeta$2;

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Zameer Manji
Applying the patch, cleaning my reports directory and then running `./gradlew clean build` produces no error for me. I can share my xml report if needed. On Thu, Oct 9, 2014 at 10:42 AM, Bill Farner wfar...@apache.org wrote: Can you post your xml report to a ticket? It might help get to the

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Joshua Cohen
Filed https://issues.apache.org/jira/browse/AURORA-822 and attached my report. On Thu, Oct 9, 2014 at 11:29 AM, Zameer Manji zma...@twopensource.com wrote: Applying the patch, cleaning my reports directory and then running `./gradlew clean build` produces no error for me. I can share my xml

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26469/#review55916 --- Ship it! Ship It! - Zameer Manji On Oct. 8, 2014, 5:15 p.m.,