Re: Review Request 17562: Added cluster name to page title.

2014-03-06 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated March 6, 2014, 11:43 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 17562: Added cluster name to page title.

2014-03-06 Thread Suman Karumuri
> On Feb. 25, 2014, 8:10 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java, line 195 > > > > > > doc here has drifted, please being it back in check Done. > On Feb. 25, 2

Re: Review Request 17562: Added cluster name to page title.

2014-02-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/#review35447 --- Ship it! src/main/java/org/apache/aurora/scheduler/http/Schedulerz

Re: Review Request 17562: Added cluster name to page title.

2014-02-24 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated Feb. 25, 2014, 1:22 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17562: Added cluster name to page title.

2014-02-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/#review35360 --- src/main/java/org/apache/aurora/scheduler/thrift/aop/APIVersionInte

Re: Review Request 17562: Added cluster name to page title.

2014-02-24 Thread Suman Karumuri
> On Feb. 22, 2014, 6:35 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/thrift/aop/APIVersionInterceptorTest.java, > > line 109 > > > > > > Rather than piecemeal equality checks, check the whol

Re: Review Request 17562: Added cluster name to page title.

2014-02-24 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated Feb. 25, 2014, 12:56 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 17562: Added cluster name to page title.

2014-02-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/#review35230 --- src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java

Re: Review Request 17562: Added cluster name to page title.

2014-02-20 Thread Suman Karumuri
> On Feb. 4, 2014, 8:52 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 231 > > > > > > Please revert. This is an anti-pattern, as tests can no lo

Re: Review Request 17562: Added cluster name to page title.

2014-02-20 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated Feb. 20, 2014, 9:53 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17562: Added cluster name to page title.

2014-02-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/#review33635 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInt

Re: Review Request 17562: Added cluster name to page title.

2014-02-04 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated Feb. 4, 2014, 8:15 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17562: Added cluster name to page title.

2014-02-03 Thread Suman Karumuri
> On Jan. 31, 2014, 12:56 a.m., Kevin Sweeney wrote: > > > > Suman Karumuri wrote: > Spoke to Bill before making these changes. We decided to use getInfo API > and deprecate getAPIVersion. The getInfo will return with the clusterName and > APIVersion for now. In future it may include other

Re: Review Request 17562: Added cluster name to page title.

2014-02-03 Thread Bill Farner
> On Jan. 31, 2014, 12:56 a.m., Kevin Sweeney wrote: > > > > Suman Karumuri wrote: > Spoke to Bill before making these changes. We decided to use getInfo API > and deprecate getAPIVersion. The getInfo will return with the clusterName and > APIVersion for now. In future it may include other

Re: Review Request 17562: Added cluster name to page title.

2014-02-03 Thread Kevin Sweeney
> On Jan. 30, 2014, 4:56 p.m., Kevin Sweeney wrote: > > > > Suman Karumuri wrote: > Spoke to Bill before making these changes. We decided to use getInfo API > and deprecate getAPIVersion. The getInfo will return with the clusterName and > APIVersion for now. In future it may include other

Re: Review Request 17562: Added cluster name to page title.

2014-01-30 Thread Suman Karumuri
> On Jan. 31, 2014, 12:56 a.m., Kevin Sweeney wrote: > > Spoke to Bill before making these changes. We decided to use getInfo API and deprecate getAPIVersion. The getInfo will return with the clusterName and APIVersion for now. In future it may include other attributes and hence the flexible

Re: Review Request 17562: Added cluster name to page title.

2014-01-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/#review33266 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInt

Review Request 17562: Added cluster name to page title.

2014-01-30 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-120

Re: Review Request 17562: Added cluster name to page title.

2014-01-30 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated Jan. 30, 2014, 10:27 p.m.) Review request for Aurora, Kevin Sweeney an