Re: Review Request 18241: Reworked LogStorage to avoid unnecessary extra calls to write().

2014-02-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18241/#review35453 --- Ship it! Ship It! - Kevin Sweeney On Feb. 20, 2014, 5:16 p.m.,

Re: Review Request 18241: Reworked LogStorage to avoid unnecessary extra calls to write().

2014-02-20 Thread Maxim Khutornenko
On Feb. 19, 2014, 5:13 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line 539 https://reviews.apache.org/r/18241/diff/1/?file=497164#file497164line539 This is too easy to forget. Any chance this assert could be moved into

Re: Review Request 18241: Reworked LogStorage to avoid unnecessary extra calls to write().

2014-02-19 Thread Bill Farner
On Feb. 19, 2014, 5:13 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line 539 https://reviews.apache.org/r/18241/diff/1/?file=497164#file497164line539 This is too easy to forget. Any chance this assert could be moved into