Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/#review52192 --- Ship it! Ship It! - Brian Wickman On Sept. 3, 2014, 4:06 a.m.,

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/#review52198 --- Ship it!

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-03 Thread Joe Smith
On Sept. 3, 2014, 10:42 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/executor/thermos_task_runner.py, line 23 https://reviews.apache.org/r/25208/diff/5/?file=674717#file674717line23 mesos_pb2 looks a bit cryptic here. How about the approach you sued elsewhere:

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/#review52049 --- the test coverage is a great improvement. thanks joe! what's the

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/ --- (Updated Sept. 2, 2014, 5:45 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
On Sept. 2, 2014, 11:08 a.m., Brian Wickman wrote: the test coverage is a great improvement. thanks joe! what's the status of mesos.native + the e2e test? abi incompatible with our vagrant image? Still working on it- Zameer claims success, but I'm waiting to pull down + provision

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
On Sept. 2, 2014, 11:08 a.m., Brian Wickman wrote: src/main/python/apache/aurora/executor/thermos_task_runner.py, lines 45-50 https://reviews.apache.org/r/25208/diff/3/?file=672643#file672643line45 should these be mesos_pb2.TASK_LOST mesos_pb2.TASK_KILLED

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/ --- (Updated Sept. 2, 2014, 9:06 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-08-30 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/ --- (Updated Aug. 29, 2014, 11:02 p.m.) Review request for Aurora, Kevin Sweeney,

Review Request 25208: Increment Mesos version to 0.20.0

2014-08-29 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/ --- Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman.

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-08-29 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/ --- (Updated Aug. 29, 2014, 4:58 p.m.) Review request for Aurora, Kevin Sweeney,