Re: Review Request 25791: Save instance update events when updating a job.

2014-09-18 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/#review53873 --- Ship it! Ship It! - David McLaughlin On Sept. 18, 2014, 8:54 p.m

Re: Review Request 25791: Save instance update events when updating a job.

2014-09-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/ --- (Updated Sept. 18, 2014, 8:54 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25791: Save instance update events when updating a job.

2014-09-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/#review53870 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 18, 2014, 8:48 p.

Re: Review Request 25791: Save instance update events when updating a job.

2014-09-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/ --- (Updated Sept. 18, 2014, 8:48 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25791: Save instance update events when updating a job.

2014-09-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/ --- (Updated Sept. 18, 2014, 8:45 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25791: Save instance update events when updating a job.

2014-09-18 Thread Bill Farner
> On Sept. 18, 2014, 8:42 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > line 447 > > > > > > Do we have any sort of guidelines on using Preconditions

Re: Review Request 25791: Save instance update events when updating a job.

2014-09-18 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/#review53867 --- src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControll

Review Request 25791: Save instance update events when updating a job.

2014-09-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs: AURORA