Re: Review Request 26288: Fixing log_response in context.py

2014-10-07 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/#review55650 --- Ship it! Looks good, thanks for changing the approach. Can you

Re: Review Request 26288: Fixing log_response in context.py

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/#review55522 --- src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 26288: Fixing log_response in context.py

2014-10-06 Thread Maxim Khutornenko
On Oct. 6, 2014, 5:12 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/context.py, line 131 https://reviews.apache.org/r/26288/diff/1/?file=712783#file712783line131 When I wrote code that did that check, Bill specifically told me to remove it, because

Re: Review Request 26288: Fixing log_response in context.py

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/#review55531 --- src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 26288: Fixing log_response in context.py

2014-10-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/ --- (Updated Oct. 6, 2014, 11:40 p.m.) Review request for Aurora and Mark

Review Request 26288: Fixing log_response in context.py

2014-10-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/ --- Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-786