Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.

2014-10-17 Thread Maxim Khutornenko
On Oct. 15, 2014, 12:41 a.m., Bill Farner wrote: src/main/python/apache/aurora/executor/gc_executor.py, line 281 https://reviews.apache.org/r/26664/diff/1/?file=719806#file719806line281 More context? It's not clear what you mean here. Added. On Oct. 15, 2014, 12:41 a.m., Bill

Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.

2014-10-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26664/ --- (Updated Oct. 17, 2014, 4:15 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.

2014-10-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26664/#review56813 --- Ship it! Ship It! - Joshua Cohen On Oct. 13, 2014, 11:22 p.m.,

Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.

2014-10-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26664/#review56599 ---

Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.

2014-10-14 Thread Bill Farner
On Oct. 14, 2014, 11:26 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java, line 183 https://reviews.apache.org/r/26664/diff/1/?file=719801#file719801line183 Isn't this unsafe? Seems like we need to treat the state the same in

Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.

2014-10-14 Thread Maxim Khutornenko
On Oct. 14, 2014, 11:26 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java, line 183 https://reviews.apache.org/r/26664/diff/1/?file=719801#file719801line183 Isn't this unsafe? Seems like we need to treat the state the same in

Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.

2014-10-14 Thread Bill Farner
On Oct. 14, 2014, 11:26 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java, line 183 https://reviews.apache.org/r/26664/diff/1/?file=719801#file719801line183 Isn't this unsafe? Seems like we need to treat the state the same in

Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.

2014-10-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26664/#review56621 --- Ship it! src/main/python/apache/aurora/executor/gc_executor.py