Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/#review62606 --- Does this code have test coverage? I can't see any tests that

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-21 Thread Kevin Sweeney
On Nov. 21, 2014, 11:34 a.m., David McLaughlin wrote: Does this code have test coverage? I can't see any tests that validate chunking is performing in the intended way. Existing test coverage in LogManagerTest validates the on-disk chunked format is the same. This is only a refactor to

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-21 Thread David McLaughlin
On Nov. 21, 2014, 7:34 p.m., David McLaughlin wrote: Does this code have test coverage? I can't see any tests that validate chunking is performing in the intended way. Kevin Sweeney wrote: Existing test coverage in LogManagerTest validates the on-disk chunked format is the same.

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-21 Thread Bill Farner
On Nov. 21, 2014, 7:34 p.m., David McLaughlin wrote: Does this code have test coverage? I can't see any tests that validate chunking is performing in the intended way. Kevin Sweeney wrote: Existing test coverage in LogManagerTest validates the on-disk chunked format is the same.

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/#review62639 --- Ship it! Ship It! - David McLaughlin On Nov. 21, 2014, 1:53

Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-930

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/#review62477 --- Master (ada97bd) is red with this patch.

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/#review62479 --- Ship it!

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/#review62481 ---

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/ --- (Updated Nov. 20, 2014, 5:10 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/#review62483 --- Master (ada97bd) is red with this patch.

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/#review62484 --- @ReviewBot retry - Kevin Sweeney On Nov. 20, 2014, 5:10 p.m.,

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Kevin Sweeney
On Nov. 20, 2014, 5:09 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java, line 92 https://reviews.apache.org/r/28306/diff/1/?file=771713#file771713line92 Mind commenting on the algorithm here? Why the magic -2? Not sure

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/#review62493 --- Ship it! Master (ada97bd) is green with this patch.

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Maxim Khutornenko
On Nov. 21, 2014, 1:09 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java, line 92 https://reviews.apache.org/r/28306/diff/1/?file=771713#file771713line92 Mind commenting on the algorithm here? Why the magic -2? Kevin

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Kevin Sweeney
On Nov. 20, 2014, 5:09 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java, line 92 https://reviews.apache.org/r/28306/diff/1/?file=771713#file771713line92 Mind commenting on the algorithm here? Why the magic -2? Kevin

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Maxim Khutornenko
On Nov. 21, 2014, 1:09 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java, line 92 https://reviews.apache.org/r/28306/diff/1/?file=771713#file771713line92 Mind commenting on the algorithm here? Why the magic -2? Kevin

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/#review62502 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 21, 2014, 1:10

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/ --- (Updated Nov. 20, 2014, 5:53 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 28306: Return an iterable of frame chunks.

2014-11-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28306/#review62513 --- Ship it! Master (ada97bd) is green with this patch.