Re: Review Request 28831: Changing the default --batch-size to 1.

2014-12-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/#review64612 --- Ship it! - Bill Farner On Dec. 9, 2014, 8:18 p.m., Maxim

Re: Review Request 28831: Changing the default --batch-size to 1.

2014-12-09 Thread Maxim Khutornenko
On Dec. 9, 2014, 2:33 a.m., Bill Farner wrote: src/test/python/apache/aurora/client/cli/test_kill.py, line 134 https://reviews.apache.org/r/28831/diff/1/?file=786267#file786267line134 I believe this should be of the form `assert foo.mock_calls == [x]` Ditto elsewhere.

Re: Review Request 28831: Changing the default --batch-size to 1.

2014-12-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/ --- (Updated Dec. 9, 2014, 6:14 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 28831: Changing the default --batch-size to 1.

2014-12-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/#review64410 --- Ship it! Master (9926af3) is green with this patch.

Re: Review Request 28831: Changing the default --batch-size to 1.

2014-12-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/#review64426 --- src/test/python/apache/aurora/client/cli/test_kill.py

Re: Review Request 28831: Changing the default --batch-size to 1.

2014-12-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/ --- (Updated Dec. 9, 2014, 8:18 p.m.) Review request for Aurora and Bill Farner.

Review Request 28831: Changing the default --batch-size to 1.

2014-12-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-961

Re: Review Request 28831: Changing the default --batch-size to 1.

2014-12-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/#review64326 --- Ship it! Master (9926af3) is green with this patch.

Re: Review Request 28831: Changing the default --batch-size to 1.

2014-12-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/#review64333 --- thanks for the drive-by cleanups!