Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review73383 --- Ship it! Master (e5de618) is green with this patch. ./build-suppo

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review73350 --- Ship it! Pending green build, etc.~ - Joshua Cohen On Feb. 20, 2

Re: Review Request 30749: Port GC executor to PathDetector interface

> On Feb. 20, 2015, 11:11 p.m., Brian Wickman wrote: > > @Reviewbot retry > > Bill Farner wrote: > Is that test known to be flaky? If so, can you file a ticket? > > Brian Wickman wrote: > https://reviews.apache.org/r/30647/ should deflake it. Gotcha. - Bill ---

Re: Review Request 30749: Port GC executor to PathDetector interface

> On Feb. 10, 2015, 7:12 p.m., Joshua Cohen wrote: > > src/main/python/apache/thermos/monitoring/garbage.py, line 120 > > > > > > Are we no longer worried about the scenario where the checkpoint root > > is $HOME or /

Re: Review Request 30749: Port GC executor to PathDetector interface

> On Feb. 20, 2015, 11:11 p.m., Brian Wickman wrote: > > @Reviewbot retry > > Bill Farner wrote: > Is that test known to be flaky? If so, can you file a ticket? https://reviews.apache.org/r/30647/ should deflake it. - Brian --- Th

Re: Review Request 30749: Port GC executor to PathDetector interface

> On Feb. 20, 2015, 11:11 p.m., Brian Wickman wrote: > > @Reviewbot retry Is that test known to be flaky? If so, can you file a ticket? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review73337 --- @Reviewbot retry - Brian Wickman On Feb. 20, 2015, 7:06 p.m., Bri

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review73303 --- Master (e0e3f2e) is red with this patch. ./build-support/jenkins/b

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 20, 2015, 7:06 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30749: Port GC executor to PathDetector interface

> On Feb. 10, 2015, 7:19 p.m., Joe Smith wrote: > > src/main/python/apache/aurora/executor/gc_executor.py, line 73 > > > > > > Some documentation would go a long way here. I assume this is the way > > to go from `task_

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71831 --- src/main/python/apache/aurora/executor/bin/BUILD

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71833 --- src/main/python/apache/thermos/monitoring/garbage.py

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71741 --- Ship it! Ship It! - Zameer Manji On Feb. 9, 2015, 3:16 p.m., Bri

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71720 --- Ship it! Master (68aa285) is green with this patch. ./build-suppo

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 9, 2015, 11:16 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71705 --- Master (dcae1e8) is red with this patch. ./build-support/jenkins/b

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 9, 2015, 8:24 p.m.) Review request for Aurora, Joshua Cohen and Z

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 9, 2015, 8:22 p.m.) Review request for Aurora, Joshua Cohen and Z

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71678 --- Ship it! There is a lot of churn because of interface changes but t

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71676 --- Ship it! Master (dcae1e8) is green with this patch. ./build-suppo

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 9, 2015, 6:56 p.m.) Review request for Aurora, Joshua Cohen and Z

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71671 --- This patch does not apply cleanly on master (dcae1e8), do you need t

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 9, 2015, 6:45 p.m.) Review request for Aurora, Joshua Cohen and Z

Re: Review Request 30749: Port GC executor to PathDetector interface

> On Feb. 8, 2015, 2:20 a.m., Zameer Manji wrote: > > src/main/python/apache/aurora/executor/gc_executor.py, line 73 > > > > > > What's the benefit of using a namedtuple here? As opposed to? This means we don't have t

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71544 --- Ship it! Master (11a65d2) is green with this patch. ./build-suppo

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 7, 2015, 12:46 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 7, 2015, 2:27 a.m.) Review request for Aurora, Joshua Cohen and Z

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 6, 2015, 11:41 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71538 --- Master (11a65d2) is red with this patch. ./build-support/jenkins/b

Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1025

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71567 --- pants.ini