Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Maxim Khutornenko
On March 13, 2015, 2:30 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java, line 255 https://reviews.apache.org/r/32014/diff/1/?file=892576#file892576line255 This is a pretty weird log entry to have. Can it be done in the client

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/ --- (Updated March 13, 2015, 5:59 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/#review76419 --- Ship it! Master (128e554) is green with this patch.

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/ --- (Updated March 13, 2015, 8:05 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/ --- (Updated March 13, 2015, 8:06 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Bill Farner
On March 13, 2015, 2:30 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java, line 279 https://reviews.apache.org/r/32014/diff/1/?file=892576#file892576line279 Ditto - this really seems like it should be client-side logging. The

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-13 Thread Maxim Khutornenko
On March 13, 2015, 2:30 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java, line 255 https://reviews.apache.org/r/32014/diff/1/?file=892576#file892576line255 This is a pretty weird log entry to have. Can it be done in the client

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-12 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/#review76332 ---

Review Request 32014: Adding more logging into MaintenanceController.

2015-03-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/#review76327 --- Ship it! Master (ee1a13a) is green with this patch.