Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-27 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/#review32836 --- Ship it! I say ship this, and I imagine more will fall out as we

Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-27 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/ --- (Updated Jan. 27, 2014, 1:21 p.m.) Review request for Aurora, Jonathan Boulle

Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/#review32846 --- Ship it! i already shipited two of the previous reviews, so i'm

Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-27 Thread Mark Chu-Carroll
On Jan. 25, 2014, 6:54 p.m., Jonathan Boulle wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 378 https://reviews.apache.org/r/17185/diff/1/?file=435145#file435145line378 1sp Sorry, don't know what you mean by this. It's a line continuation, so it's indented 4; and I

Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-27 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185/#review32852 --- src/main/python/apache/aurora/client/cli/jobs.py

Review Request 17412: Quiet noisy status checker debug messages

2014-01-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17412/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps

2014-01-27 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/ --- Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.

Re: Review Request 17412: Quiet noisy status checker debug messages

2014-01-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17412/ --- (Updated Jan. 27, 2014, 9:25 p.m.) Review request for Aurora and Kevin

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/#review32887 ---

Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps

2014-01-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/#review32893 --- 3rdparty/python/BUILD

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/#review32894 ---

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Bill Farner
On Jan. 27, 2014, 9:55 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, line 89 https://reviews.apache.org/r/17372/diff/1/?file=451051#file451051line89 Would be great to have a brief write out here on how primary and

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Bill Farner
On Jan. 27, 2014, 10:18 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, line 293 https://reviews.apache.org/r/17372/diff/1/?file=451051#file451051line293 Does it make sense to special-case the primary-key index here? Seems

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/#review32900 --- Ship it! Ship It! - Kevin Sweeney On Jan. 26, 2014, 1:52 p.m.,

Re: Review Request 17412: Quiet noisy status checker debug messages

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17412/#review32901 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2014, 1:25 p.m.,

Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-27 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 17432: Fix regression causing secondary index to store duplicate tasks.

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17432/#review32916 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2014, 3:58 p.m.,

Re: Review Request 17432: Fix regression causing secondary index to store duplicate tasks.

2014-01-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17432/#review32917 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 27, 2014, 11:58

Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/#review32923 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2014, 4:19 p.m.,

Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps

2014-01-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/#review32938 --- Ship it! Ship It! - Brian Wickman On Jan. 28, 2014, 12:19 a.m.,

Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps

2014-01-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/#review32937 --- Ship it! Ship It! - Brian Wickman On Jan. 28, 2014, 12:19 a.m.,

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review32945 ---

Re: Review Request 17347: Added non-prod consumption info to getQuota call.

2014-01-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17347/#review32946 --- src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review32947 --- Can you also attach the JIRA issue please? - Bill Farner On Jan.