Re: Review Request 17562: Added cluster name to page title.

2014-02-04 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated Feb. 4, 2014, 8:15 a.m.) Review request for Aurora, Kevin Sweeney and

Review Request 17712: Fixing @Override public.

2014-02-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17712/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-04 Thread Mark Chu-Carroll
I disagree. To me, the fundamental issue is just what a quota is. Is a quota a primitive basic object which has the role/cluster/environment as an attribute? Or is the role the basic object, and the quota is an attribute of the role? I think that the quota as attribute of a user makes much more

Re: Review Request 17680: Break down free slots stats into dedicated and shared.

2014-02-04 Thread Bill Farner
On Feb. 4, 2014, 4:20 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java, line 61 https://reviews.apache.org/r/17680/diff/1/?file=463692#file463692line61 Is it public only because of MachineResourceProvider interface? It's exposed

Re: Review Request 17680: Break down free slots stats into dedicated and shared.

2014-02-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17680/ --- (Updated Feb. 4, 2014, 6:44 p.m.) Review request for Aurora and Maxim

Review Request 17715: Added THROTTLED state to scheduler UI.

2014-02-04 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17715/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-150

Re: Review Request 17715: Added THROTTLED state to scheduler UI.

2014-02-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17715/#review33623 --- Ship it! Ship It! - Bill Farner On Feb. 4, 2014, 7 p.m., Suman

Review Request 17717: License header cleanup introduced in a584410c.

2014-02-04 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17717/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 17715: Added THROTTLED state to scheduler UI.

2014-02-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17715/#review33626 --- Ship it! Ship It! - Kevin Sweeney On Feb. 4, 2014, 11 a.m.,

Re: Review Request 17672: Add indices to OfferQueueImpl to improve resource offer handling performance.

2014-02-04 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17672/#review33625 --- Ship it! The logic is much cleaner now. Since no new tests are

Re: Review Request 17717: License header cleanup introduced in a584410c.

2014-02-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17717/#review33628 ---

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-04 Thread Toby Weingartner
As a possible extension, I could see something like: aurora quota get smf1/* = return quota information for all users -Toby. On Tue, Feb 4, 2014 at 1:24 PM, Toby Weingartner tweingart...@twopensource.com wrote: What else is hung on aurora user? I think I'm in Kevin's camp... but maybe

Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails due to un-specified executor parameters in the slave configurations.

2014-02-04 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17724/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-128